refactor 53

fishercoder1534 · fishercoder1534 · commit e1b93d67c16f · 2021-09-12T11:26:09.000-07:00
diff --git a/src/main/java/com/fishercoder/solutions/_53.java b/src/main/java/com/fishercoder/solutions/_53.java
@@ -7,13 +7,13 @@ public static class Solution1 {
          * https://leetcode.com/problems/maximum-subarray/discuss/20211/accepted-on-solution-in-java
          */
         public int maxSubArray(int[] nums) {
-            int maxSoFar = nums[0];
-            int maxEndingHere = nums[0];
+            int globalMax = nums[0];
+            int currentMax = nums[0];
             for (int i = 1; i < nums.length; i++) {
-                maxEndingHere = Math.max(nums[i], maxEndingHere + nums[i]);
-                maxSoFar = Math.max(maxEndingHere, maxSoFar);
+                currentMax = Math.max(nums[i], currentMax + nums[i]);
+                globalMax = Math.max(currentMax, globalMax);
             }
-            return maxSoFar;
+            return globalMax;
         }
     }
 }
diff --git a/src/test/java/com/fishercoder/_53Test.java b/src/test/java/com/fishercoder/_53Test.java
@@ -8,22 +8,22 @@
 import static org.junit.Assert.assertEquals;
 
 public class _53Test {
-  private static _53.Solution1 solution1;
-  private static int[] nums;
+    private static _53.Solution1 solution1;
+    private static int[] nums;
 
-  @BeforeClass
-  public static void setup() {
-    solution1 = new _53.Solution1();
-  }
+    @BeforeClass
+    public static void setup() {
+        solution1 = new _53.Solution1();
+    }
 
-  @Before
-  public void clear() {
-    solution1 = new _53.Solution1();
-  }
+    @Before
+    public void clear() {
+        solution1 = new _53.Solution1();
+    }
 
-  @Test
-  public void test1() {
-    nums = new int[] {-2, 1, -3, 4, -1, 2, 1, -5, 4};
-    assertEquals(6, solution1.maxSubArray(nums));
-  }
+    @Test
+    public void test1() {
+        nums = new int[]{-2, 1, -3, 4, -1, 2, 1, -5, 4};
+        assertEquals(6, solution1.maxSubArray(nums));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -7,13 +7,13 @@ public static class Solution1 {`
`7`	`7`	`* https://leetcode.com/problems/maximum-subarray/discuss/20211/accepted-on-solution-in-java`
`8`	`8`	`*/`
`9`	`9`	`public int maxSubArray(int[] nums) {`
`10`		`- int maxSoFar = nums[0];`
`11`		`- int maxEndingHere = nums[0];`
	`10`	`+ int globalMax = nums[0];`
	`11`	`+ int currentMax = nums[0];`
`12`	`12`	`for (int i = 1; i < nums.length; i++) {`
`13`		`- maxEndingHere = Math.max(nums[i], maxEndingHere + nums[i]);`
`14`		`- maxSoFar = Math.max(maxEndingHere, maxSoFar);`
	`13`	`+ currentMax = Math.max(nums[i], currentMax + nums[i]);`
	`14`	`+ globalMax = Math.max(currentMax, globalMax);`
`15`	`15`	`}`
`16`		`- return maxSoFar;`
	`16`	`+ return globalMax;`
`17`	`17`	`}`
`18`	`18`	`}`
`19`	`19`	`}`