Skip to content

docker-java-transport-httpclient5 broken over Unix sockets (regression in httpclient5 5.4) #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
basil opened this issue Oct 28, 2024 · 3 comments
Closed

docker-java-transport-httpclient5 broken over Unix sockets (regression in httpclient5 5.4) #2363

basil opened this issue Oct 28, 2024 · 3 comments

Comments

@basil
Copy link

basil commented Oct 28, 2024

Steps to reproduce

Clone https://github.com/docker-java/docker-java.git and apply

diff --git a/docker-java-transport-httpclient5/pom.xml b/docker-java-transport-httpclient5/pom.xml
index 48b751d5..808855f2 100644
--- a/docker-java-transport-httpclient5/pom.xml
+++ b/docker-java-transport-httpclient5/pom.xml
@@ -29,7 +29,7 @@
                 <dependency>
                         <groupId>org.apache.httpcomponents.client5</groupId>
                         <artifactId>httpclient5</artifactId>
-                        <version>5.0.3</version>
+                        <version>5.4</version>
                 </dependency>

and run mvn clean verify -Dtest=HttpClient5Tests -DfailIfNoTests=false -DskipITs

Expected results

Note: These are the actual results with httpclient5 5.0.3 and 5.3.1.

Tests pass.

Actual results

Tests fail with

java.lang.RuntimeException: org.apache.hc.client5.http.HttpHostConnectException: Connect to unix://localhost:2375 [localhost/127.0.0.1, localhost/0:0:0:0:0:0:0:1] failed: Connection refused
	at com.github.dockerjava.httpclient5.ApacheDockerHttpClientImpl.execute(ApacheDockerHttpClientImpl.java:210)
	at com.github.dockerjava.httpclient5.ApacheDockerHttpClient.execute(ApacheDockerHttpClient.java:9)
	at com.github.dockerjava.core.DefaultInvocationBuilder.execute(DefaultInvocationBuilder.java:228)
	at com.github.dockerjava.core.DefaultInvocationBuilder.lambda$executeAndStream$1(DefaultInvocationBuilder.java:269)
	at java.base/java.lang.Thread.run(Thread.java:1583)
Caused by: org.apache.hc.client5.http.HttpHostConnectException: Connect to unix://localhost:2375 [localhost/127.0.0.1, localhost/0:0:0:0:0:0:0:1] failed: Connection refused
	at java.base/sun.nio.ch.Net.pollConnect(Native Method)
	at java.base/sun.nio.ch.Net.pollConnectNow(Net.java:682)
	at java.base/sun.nio.ch.NioSocketImpl.timedFinishConnect(NioSocketImpl.java:542)
	at java.base/sun.nio.ch.NioSocketImpl.connect(NioSocketImpl.java:592)
	at java.base/java.net.SocksSocketImpl.connect(SocksSocketImpl.java:327)
	at java.base/java.net.Socket.connect(Socket.java:751)
	at org.apache.hc.client5.http.impl.io.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:216)
	at org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:490)
	at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:164)
	at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:174)
	at org.apache.hc.client5.http.impl.classic.ConnectExec.execute(ConnectExec.java:144)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.ProtocolExec.execute(ProtocolExec.java:192)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.ContentCompressionExec.execute(ContentCompressionExec.java:150)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.HttpRequestRetryExec.execute(HttpRequestRetryExec.java:113)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.RedirectExec.execute(RedirectExec.java:110)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.InternalHttpClient.doExecute(InternalHttpClient.java:174)
	at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:87)
	at com.github.dockerjava.httpclient5.ApacheDockerHttpClientImpl.execute(ApacheDockerHttpClientImpl.java:206)

Evaluation

Bisection shows this regression was caused by apache/httpcomponents-client@851c8df9f in apache/httpcomponents-client#540 by @ok2c. See also HTTPCLIENT-2348.
This was referenced Oct 28, 2024
Closed
Closed
@basil
Copy link
Author

basil commented Oct 28, 2024

@bsideup @eddumelendez @Sineaggi FYI

@ok2c
Copy link
Contributor

ok2c commented Oct 29, 2024 •
edited
Loading

@basil Here's the PR that upgrades Apache HttpClient to version 5.4.1 and corrects connection initialization of non-HTTP protocol schemes: #2364

@basil basil mentioned this issue Oct 29, 2024
Merged
@denis-yuen denis-yuen mentioned this issue Nov 6, 2024
Merged
9 tasks
@basil basil mentioned this issue Nov 23, 2024
Closed
@mattnelson mattnelson mentioned this issue Feb 25, 2025
Open
@StefanPenndorf StefanPenndorf mentioned this issue Feb 27, 2025
Closed
@eddumelendez eddumelendez marked this as a duplicate of #2366 Apr 1, 2025
@eddumelendez eddumelendez marked this as a duplicate of #2380 Apr 1, 2025
@eddumelendez
Copy link
Member

Version 3.5.0 has been released and it contains a @ok2c contributiin.

@devminded devminded mentioned this issue May 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@basil @ok2c @eddumelendez