Skip to content

Support TLS configuration from docker context #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2023
Merged

Support TLS configuration from docker context #2105

merged 2 commits into from
May 29, 2023

Conversation

piotrwielgolaski-tomtom
Copy link
Contributor

It is small extension to support TLS part of configuration from docker context

Continuation of issue #1946

@piotrwielgolaski-tomtom
Copy link
Contributor Author

@eddumelendez as you reviewed original PR #2036 maybe you could take a look at this one as well?

@piotrwielgolaski-tomtom
Copy link
Contributor Author

kindly reminder, what can I do to make it part of main?

@eddumelendez eddumelendez self-assigned this May 7, 2023
@piotrwielgolaski-tomtom
Copy link
Contributor Author

@eddumelendez any change you can take a look at it?
I would love to make test containeraware of docker context

@eddumelendez
Copy link
Member

@piotrwielgolaski-tomtom sorry for the delay, can you please amend the last commit in order to perform a force push, please? IDK the reason why CI didn't execute.

@piotrwielgolaski-tomtom
Copy link
Contributor Author

Sorry what should I change? Only rebase or should I change something? I don't send check, so it is hard to understand what is wrong.

@eddumelendez
Copy link
Member

Running git commit --amend should work and then git push -f

supporting TLS in case remote docker host is used
@piotrwielgolaski-tomtom
Copy link
Contributor Author

piotrwielgolaski-tomtom commented May 25, 2023

I added extra description in commit and push it again, I hope it will helps.
Let me know if I can do anything to push it forward.

@eddumelendez
Copy link
Member

I'm able to approve and now checks are running. Thanks!

@eddumelendez eddumelendez merged commit dddd439 into docker-java:main May 29, 2023
@eddumelendez eddumelendez added this to the next milestone May 29, 2023
@eddumelendez
Copy link
Member

Thanks for your contribution, @piotrwielgolaski-tomtom ! and sorry for the delay. This will be available in the next version

@piotrwielgolaski-tomtom piotrwielgolaski-tomtom deleted the faeture/tls_settings_from_context branch June 3, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants