Simplify docker-entrypoint.sh append one line to EOF
#270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Mar 30, 2017
9.6/docker-entrypoint.sh
Outdated
| { echo; echo "host all all all $authMethod"; } | tee -a "$PGDATA/pg_hba.conf" > /dev/null | ||
|
|
||
| echo "" >> $PGDATA/pg_hba.conf | ||
| echo "host all all all $authMethod" >> $PGDATA/pg_hba.conf |
There was a problem hiding this comment.
Ah, the | tee ... was a remnant from when we actually had to do | gosu postgres tee ....
IMO, we should instead add some whitespace and use >> now, ala:
{
echo
echo "host all all all $authMethod"
} >> "$PGDATA/pg_hba.conf"
tianon
approved these changes
Apr 6, 2017
yosifkit
approved these changes
Apr 6, 2017
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Apr 7, 2017
- `drupal`: 8.3.0 (docker-library/drupal#78), remove 8.2 (docker-library/drupal#80) - `ghost`: add `alpine` variant (docker-library/ghost#55) - `mongo`: more edge cases (docker-library/mongo#167, docker-library/mongo#169) - `postgres`: adjust append (docker-library/postgres#270) - `rabbitmq`: add `vm_memory_high_watermark` support based on cgroup limits (docker-library/rabbitmq#105) - `rocket.chat`: 0.55.0-rc.1 - `wordpress`: add `wp-cli` variant (docker-library/wordpress#198)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, but not all developers know this extra bash syntax.
But please keep it simple for other developers.
If readability is not so important for you just close this pull.
Thanks