-
Notifications
You must be signed in to change notification settings - Fork 1.1k
find_library broken in alpine image #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Alpine image may need to apply the same patch to make |
@ushuz The patch we use in alpine is incomplete. The fundamental problem is when you try to dlopen libc itself, then bad things will happen. upstream musl libc has said they will fix but I don't know what the status is there. We should probably report this to upstream python. |
@ncopa But why calling |
Twisted server: monkey-patch file |
I'm a little confused here -- what's the use case for |
As noted above, $ docker run --rm alpine:3.7 cat /sbin/ldconfig
#!/bin/sh
scan_dirs() {
scanelf -qS "$@" | while read SONAME FILE; do
TARGET="${FILE##*/}"
LINK="${FILE%/*}/$SONAME"
case "$FILE" in
/lib/*|/usr/lib/*|/usr/local/lib/*) ;;
*) [ -h "$LINK" -o ! -e "$LINK" ] && ln -sf "$TARGET" "$LINK"
esac
done
return 0
}
# eat ldconfig options
while getopts "nNvXvf:C:r:" opt; do
:
done
shift $(( $OPTIND - 1 ))
[ $# -gt 0 ] && scan_dirs "$@" |
As mentioned in the SO link above, Twisted's inotify implementation uses
CPython's stdlib So I tried installing
|
alpine maintainers apply the following patch : https://github.com/alpinelinux/aports/blob/master/main/python2/musl-find_library.patch can you put the same in the image ? |
Did anyone end up doing so? (not seeing a link anywhere in the comments here) They definitely won't fix it if they don't know it's an issue. 😅 |
It looks like https://bugs.python.org/issue21622 is probably the right place. |
To clarify, this is definitely an issue, and definitely something that ought to be fixed, but I'm not keen on the implementation in https://github.com/alpinelinux/aports/blob/202f4bea916b0cf974b38ced96ab8fca0b192e3f/main/python2/musl-find_library.patch especially given that it's very Alpine-specific and doesn't appear to have had any review by the Python maintainers (which I'd want for something that patches the standard library). I think what's needed here is a patch that Python upstream would be willing to consider and/or merge themselves, and I haven't seen anyone propose anything like that (and there's been no response to my ping on the upstream bug several months ago). |
I've submitted some PRs for cpython master, which should backport to 3.7 with minimal fuss considering there are no conflicts with the util.py file. In the 3.7 branch, they have the ldconfig, gcc and objdump methods that reference the LD_LIBRARY_PATH to get names. I took the implementation above to walk that path referenced above and removed the alpine specific checks. My opinion is that the decision for which library name is being sought should be maintained by the library/app based on the detection for the environment it is in or the user of the app/library to configure/override where applicable. Once you know which library name you want to find, and for the posix case, the LD_LIBRARY_PATH can determine where to search which is within the user's control and within the responsibility of the find_library function. At least for my case, I can use the alpine:3.8 image, set |
Closing in favor of the upstream tracking issue (https://bugs.python.org/issue21622), since this is really an upstream bug. 😅 ❤️ |
In the meantime why can't a patch be made for Alpine specifically? E.g. something like below? It would help a lot since people wouldn't need to build Python themselves or write a script to symlink libraries to a |
Last time I looked at / considered python/cpython#18380, it appeared to be more fundamentally controversial than it is now, so this is indeed probably something we should seriously consider applying and keeping up with (especially given that per PEP 11, Alpine/musl is not a supported platform, so it seems reasonable for us to consider carrying this patch unless/until that's resolved). |
@tianon that would be fantastic and thank you for reopening, it's one of those gotchas that people run into and spend hours debugging. |
@tianon would you be open to PRs to add this functionality across all the Python versions? I may have some free time to help out. |
Yes, but the biggest challenge (that I don't have a simple answer to atm) is going to be finding a clean way to maintain the patch, especially with the necessary changes for different Python versions. Ideally we'd just download it directly from a URL like Something like a hacky " |
According to http://bugs.alpinelinux.org/issues/5264 its known, that find_library is broken with python3 on Alpine.
However, with python2 it works on pure alpine:3.3,
but not on python:2-alpine,
so python:2-alpine seems to break something in addition to the general alpine issue, which renders even version 2 broken. Maybe the find_library issue could also be worked around by python image in general.
The text was updated successfully, but these errors were encountered: