docsify-server-renderer error #704

ccforeverd · 2018-11-19T08:44:14Z

My code here:

// docs-renderer.js
const fs = require('fs')
const path = require('path')
const docsifyRenderer = require('docsify-server-renderer')
const templatePath = path.resolve(__dirname, '../../docs/index.template.html')

const docsifyConfig = {
  basePath: '/src',
  // ...
}

const renderer = new docsifyRenderer({
  template: fs.readFileSync(templatePath, 'utf-8'),
  config: docsifyConfig
})

async function test () {
  renderer.renderToString('docs/')
    .then(console.log)
    .catch(console.log)
}

test()

module.exports = renderer

Then:

TypeError: Cannot read property 'indexOf' of undefined
    at AbstractHistory.parse (/Users/zhangshuyao/Sites/git/docs/node_modules/docsify-server-renderer/build.js:349:30)
    at Compiler.compile (/Users/zhangshuyao/Sites/git/docs/node_modules/docsify-server-renderer/build.js:553:37)
    at Renderer.<anonymous> (/Users/zhangshuyao/Sites/git/docs/node_modules/docsify-server-renderer/build.js:1126:28)
    at Generator.next (<anonymous>)
    at c (/Users/zhangshuyao/Sites/git/docs/node_modules/docsify-server-renderer/build.js:14:99)
    at process._tickCallback (internal/process/next_tick.js:68:7)
    at Function.Module.runMain (internal/modules/cjs/loader.js:744:11)
    at startup (internal/bootstrap/node.js:285:19)
    at bootstrapNodeJSCore (internal/bootstrap/node.js:739:3)

There is shotcut of docsify-server-renderer/build.js

// line 553
  var curFileName = this$1.router.parse().file;
// line 346-360
  AbstractHistory.prototype.parse = function parse (path$$1) {
    var query = '';

    var queryIndex = path$$1.indexOf('?');
    if (queryIndex >= 0) {
      query = path$$1.slice(queryIndex + 1);
      path$$1 = path$$1.slice(0, queryIndex);
    }

    return {
      path: path$$1,
      file: this.getFile(path$$1),
      query: parseQuery(query)
    }
  };

I think maybe there is something wrong with my code or build.js after rollup-build, pls help me to check it.

Best

The text was updated successfully, but these errors were encountered:

ccforeverd · 2018-11-19T08:47:46Z

My work dir:

src
- docs
  - ...
  - index.template.html
- server
  - controller
    - docs-renderer.js
  - router
    - docs.js
    - index.js
  - index.js
package.json
...

ccforeverd · 2018-11-19T08:51:29Z

// src/server/router/docs.js

require('colors')
const path = require('path')
const send = require('koa-send')
const renderer = require('../controller/docs-renderer')

const docsDir = path.resolve(__dirname, '../../docs')

const routerName = 'docs'
const routerPath = '/docs/(.*)?'
const routerHandler = async ctx => {
  const sendPath = ctx.path.replace(`/${routerName}`, '') || '/'
  const sendOptions = {
    root: docsDir,
    index: 'index.html'
  }

  try {
    await send(ctx, sendPath, sendOptions)
  } catch (e) {
    console.log(`[${'send'.magenta} ${'404'.red}] ${ctx.path}`)
  }
}

module.exports = {
  name: routerName,
  path: routerPath,
  handler: routerHandler
}

ccforeverd · 2018-11-19T09:02:30Z

When i visit http://localhost:3333/docs#/, it's all OK with router model hash. But if i try ssr, there is allways a error of parse.

Pls see:

docsify/src/core/render/compiler.js

Line 121 in a257a4a

const curFileName = this.router.parse().file

docsify/src/core/router/history/abstract.js

Line 10 in a257a4a

parse(path) {

The method parse real need an argument of path

yatagasaru · 2018-12-14T06:57:51Z

I have the same problem

const Renderer = require('docsify-server-renderer')
const readFileSync = require('fs').readFileSync
const express = require ('express');

const app = express();

let renderer = new Renderer({
    template: readFileSync('./docs/index.template.html', 'utf-8'),
    config: {
        name: 'Test',
        basePath: '/docs',
        repo: 'te/st',
        loaddNavbar: true, 
        loadSidebar: true, 
        subMaxLevel: 3, 
        auto2top: true
    }
})
app.get('*', (req, res) =>{
    renderer.renderToString(req.url, (html, err) =>{
        if(err) throw err
        console.log(html)
    })
})
app.listen(3000, console.log("RUNING ON PORT 3000"))

TypeError: Cannot read property 'indexOf' of undefined
    at AbstractHistory.parse (/home/ga/tes/ns/doc/node_modules/docsify-server-renderer/build.js:349:30)
    at Compiler.compile (/home/ga/tes/ns/doc/node_modules/docsify-server-renderer/build.js:553:37)
    at Renderer.<anonymous> (/home/ga/tes/ns/doc/node_modules/docsify-server-renderer/build.js:1126:28)
    at Generator.next (<anonymous>)
    at c (/home/ga/tes/ns/doc/node_modules/docsify-server-renderer/build.js:14:99)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:189:7)

bitkris-dev · 2018-12-21T13:28:23Z

I've the exact same error. I'm trying to use docsify with SSR using docsify-server-renderer but seems impossible. Also, the documentation talks about a renderer.renderToString(url) but it's not explained what the "url" parameter should be.

@QingWei-Li Can you take a look, please?

jthegedus · 2019-01-06T05:26:33Z

Has anyone been able to identify which was the last working version of docsify?

kaesar · 2019-01-15T21:00:05Z

About docsify-server-renderer/build.js, even if you change this ...

// line 346-360
  AbstractHistory.prototype.parse = function parse (path$$1) {
    var query = '';

    var queryIndex = path$$1.indexOf('?');
    if (queryIndex >= 0) {
      query = path$$1.slice(queryIndex + 1);
      path$$1 = path$$1.slice(0, queryIndex);
    }

    return {
      path: path$$1,
      file: this.getFile(path$$1),
      query: parseQuery(query)
    }
  };

by ... (around line 349)

// line 346-360
  AbstractHistory.prototype.parse = function parse (path$$1) {
    var query = '';
    var queryIndex = -1;                             // new
    if (path$$1) queryIndex = path$$1.indexOf('?');  // edited
    if (queryIndex >= 0) {
      query = path$$1.slice(queryIndex + 1);
      path$$1 = path$$1.slice(0, queryIndex);
    }

    return {
      path: path$$1,
      file: this.getFile(path$$1),
      query: parseQuery(query)
    }
  };

It works apparently or simply avoid the error. But I got another situation, may be with the basePath, because the README.md file don't load.
I don't know if I'm wrong, but it seems that if you use docsify-cli it doesn't render the content for better SEO either.

zmnv · 2019-02-08T09:52:25Z

Same error! Just download https://github.com/docsifyjs/docsify-ssr-demo
npm install
npm start

[SSR] Serving . now.
Listening at http://localhost:4000

TypeError: Cannot read property 'indexOf' of undefined

zmnv · 2019-02-08T09:55:54Z

just download master branch.

npm run serve:ssr

> docsify@4.8.6 serve:ssr /Users/user/docsify-master
> cross-env SSR=1 node server

Serving "/Users/user/docsify-master" at http://127.0.0.1:3000
Ready for changes
Ready for changes
(node:2594) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'indexOf' of undefined

zmnv · 2019-02-08T10:24:18Z

All works with old 4.1.7 version.

"docsify-cli": "^4.1.7",

Last version 4.3.0 returns error

zmnv · 2019-03-12T10:45:47Z

No. Something wrong.. Can you update docsify-cli or ssr example repo, pls?

llwor94 · 2019-04-10T03:55:14Z

i'm having the same issue... anyone have any luck?

wll8 · 2019-04-16T07:05:08Z

It seems that the examples on docsify-ssr-demo are incomplete and incorrect.
I don't know why.

I don't know how https://docsify.now.sh/ssr is implemented.

git clone https://github.com/docsifyjs/docsify-ssr-demo
cd docsify-ssr-demo
npm i 
npm start
# open http://localhost:4000
# TypeError: Cannot read property 'indexOf' of undefined

git clone https://github.com/docsifyjs/docsify
cd docsify
npm i
npm run dev:ssr
# open http://localhost:3000
# UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'indexOf' of undefined

randyguogithub · 2019-04-24T03:22:57Z

The same error found, even upgrade to the latest version of docsify

jinguowu · 2019-05-13T08:16:41Z

The same error found, even upgrade to the latest version of docsify 4.3

loverajoel · 2019-06-19T20:05:14Z

Same here, any update?

In order to use, just build then pack the dependency: ``` npm run build npm pack packages/docsify-server-renderer/ ```

naihe138 · 2019-09-12T04:16:21Z

The same error found, even upgrade to the latest version of docsify

stale · 2020-02-04T08:37:24Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

mattvb91 · 2020-07-17T14:08:45Z

Still having this issue. Did anyone manage to find a fix?

boxsnake · 2020-07-21T19:23:04Z

I looked around the code, and found the possible reason:

It seems that the "main" render part resolve relative paths to absolute paths before rendering.
And when _renderFile is called, for absolute paths, the function uses fetch to get file.
Since fetch is not available for local files without a file:// scheme, the fetch won't work.
As a result, the content is empty.

equinusocio · 2020-09-05T10:17:37Z

Same here with v4.4.1. Is the fix already released?

See this problem in issue: docsifyjs#704

QingWei-Li added a commit that referenced this issue Feb 19, 2019

fix(ssr): AbstractHistory.parse error fix #704

0f06994

QingWei-Li added a commit that referenced this issue Feb 19, 2019

fix(ssr): AbstractHistory.parse error fix #704

6e5da56

QingWei-Li added a commit that referenced this issue Mar 31, 2019

fix(ssr): AbstractHistory.parse error fix #704

4036bd8

yubaolee added a commit to yubaolee/docsify that referenced this issue Jun 30, 2019

fix docsifyjs#704

703730c

jliben pushed a commit to jliben/docsify that referenced this issue Sep 9, 2019

Temp fix until docsifyjs#704 gets fixed:

a01afd4

In order to use, just build then pack the dependency: ``` npm run build npm pack packages/docsify-server-renderer/ ```

stale bot added the wontfix label Feb 4, 2020

stale bot closed this as completed Feb 11, 2020

theBliz mentioned this issue Feb 25, 2020

SSR not working docsifyjs/docsify-cli#95

Closed

1 task

mattvb91 mentioned this issue Jul 17, 2020

Server Side Rendering appears to no longer work #1101

Closed

1 task

jeffusion pushed a commit to jeffusion/docsify that referenced this issue Aug 19, 2021

fix: ssr TypeError: Cannot read property 'indexOf' of undefined

f6aae93

See this problem in issue: docsifyjs#704

jeffusion pushed a commit to jeffusion/docsify that referenced this issue Aug 19, 2021

fix: ssr TypeError: Cannot read property 'indexOf' of undefined

425553b

See this problem in issue: docsifyjs#704

jeffusion mentioned this issue Aug 19, 2021

fix: ssr TypeError: Cannot read property 'indexOf' of undefined #1627

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docsify-server-renderer error #704

docsify-server-renderer error #704

ccforeverd commented Nov 19, 2018

ccforeverd commented Nov 19, 2018 •

edited

Loading

ccforeverd commented Nov 19, 2018

ccforeverd commented Nov 19, 2018 •

edited

Loading

yatagasaru commented Dec 14, 2018

bitkris-dev commented Dec 21, 2018

jthegedus commented Jan 6, 2019

kaesar commented Jan 15, 2019 •

edited

Loading

zmnv commented Feb 8, 2019

zmnv commented Feb 8, 2019 •

edited

Loading

zmnv commented Feb 8, 2019 •

edited

Loading

zmnv commented Mar 12, 2019

llwor94 commented Apr 10, 2019

wll8 commented Apr 16, 2019 •

edited

Loading

randyguogithub commented Apr 24, 2019

jinguowu commented May 13, 2019

loverajoel commented Jun 19, 2019

naihe138 commented Sep 12, 2019

stale bot commented Feb 4, 2020

mattvb91 commented Jul 17, 2020

boxsnake commented Jul 21, 2020 •

edited

Loading

equinusocio commented Sep 5, 2020 •

edited

Loading

docsify-server-renderer error #704

docsify-server-renderer error #704

Comments

ccforeverd commented Nov 19, 2018

ccforeverd commented Nov 19, 2018 • edited Loading

ccforeverd commented Nov 19, 2018

ccforeverd commented Nov 19, 2018 • edited Loading

yatagasaru commented Dec 14, 2018

bitkris-dev commented Dec 21, 2018

jthegedus commented Jan 6, 2019

kaesar commented Jan 15, 2019 • edited Loading

zmnv commented Feb 8, 2019

zmnv commented Feb 8, 2019 • edited Loading

zmnv commented Feb 8, 2019 • edited Loading

zmnv commented Mar 12, 2019

llwor94 commented Apr 10, 2019

wll8 commented Apr 16, 2019 • edited Loading

randyguogithub commented Apr 24, 2019

jinguowu commented May 13, 2019

loverajoel commented Jun 19, 2019

naihe138 commented Sep 12, 2019

stale bot commented Feb 4, 2020

mattvb91 commented Jul 17, 2020

boxsnake commented Jul 21, 2020 • edited Loading

equinusocio commented Sep 5, 2020 • edited Loading

ccforeverd commented Nov 19, 2018 •

edited

Loading

ccforeverd commented Nov 19, 2018 •

edited

Loading

kaesar commented Jan 15, 2019 •

edited

Loading

zmnv commented Feb 8, 2019 •

edited

Loading

zmnv commented Feb 8, 2019 •

edited

Loading

wll8 commented Apr 16, 2019 •

edited

Loading

boxsnake commented Jul 21, 2020 •

edited

Loading

equinusocio commented Sep 5, 2020 •

edited

Loading