Skip to content

Fix type error #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix type error #984

wants to merge 1 commit into from

Conversation

norkunas
Copy link
Contributor

Having SET sql_mode=(SELECT REPLACE(@@sql_mode, 'ONLY_FULL_GROUP_BY', '')) query and when clicking on explain currently it throws:

Argument 2 passed to Doctrine\DBAL\Connection::resolveParams() must be of the type array, null given, called in /vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php on line 911

@norkunas norkunas changed the base branch from 1.12.x to 1.11.x June 20, 2019 07:59
@greg0ire
Copy link
Member

Weird… can you provide the full stack trace? I think a better fix might be to ensure types is always set.

@norkunas
Copy link
Contributor Author

To be clear: this should be fixed in sf bridge, right?

@norkunas
Copy link
Contributor Author

I'll provide stacktrace next week.

@greg0ire
Copy link
Member

To be clear: this should be fixed in sf bridge, right?

I have no idea, but a stack trace might help with this ;)

@norkunas
Copy link
Contributor Author

Here you go:

(1/1) TypeError
Argument 2 passed to Doctrine\DBAL\Connection::resolveParams() must be of the type array, null given, called in /vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php on line 911

in Connection.php line 1595
at Connection->resolveParams(array(), null)
in Connection.php line 911
at Connection->executeQuery('EXPLAIN SET sql_mode=(SELECT REPLACE(@@sql_mode, \'ONLY_FULL_GROUP_BY\', \'\'))', array(), null)
in ProfilerController.php line 101
at ProfilerController->explainOtherPlatform(object(Connection), array('sql' => 'SET sql_mode=(SELECT REPLACE(@@sql_mode, \'ONLY_FULL_GROUP_BY\', \'\'))', 'params' => object(Data), 'types' => null, 'executionMS' => 0.01961493492126465, 'explainable' => true))
in ProfilerController.php line 61
at ProfilerController->explainAction('114c47', 'default', array('sql' => 'SET sql_mode=(SELECT REPLACE(@@sql_mode, \'ONLY_FULL_GROUP_BY\', \'\'))', 'params' => object(Data), 'types' => null, 'executionMS' => 0.01961493492126465, 'explainable' => true))
in HttpKernel.php line 151
at HttpKernel->handleRaw(object(Request), 2)
in HttpKernel.php line 68
at HttpKernel->handle(object(Request), 2, false)
in SubRequestHandler.php line 85
at SubRequestHandler::handle(object(HttpKernel), object(Request), 2, false)
in InlineFragmentRenderer.php line 81
at InlineFragmentRenderer->render('/_fragment?_path=_format%3Dhtml%26_locale%3Den%26_controller%3DDoctrineBundle%253AProfiler%253Aexplain', object(Request), array('ignore_errors' => false))
in FragmentHandler.php line 87
at FragmentHandler->render(object(ControllerReference), 'inline', array('ignore_errors' => false))
in LazyLoadingFragmentHandler.php line 45
at LazyLoadingFragmentHandler->render(object(ControllerReference), 'inline', array())
in HttpKernelRuntime.php line 46
at HttpKernelRuntime->renderFragment(object(ControllerReference))
in 79a9aff25a9aa7e151c8edfe233223a7c9205d704571736e49edc2e106ad36a9.php line 351
at __TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d->block_panel(array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2, 'app' => object(AppVariable), 'frontend_url' => 'https://localhost:3030'), array('head' => array(object(__TwigTemplate_13ffe3535b5555273d03e7839e3646a5b2ed30b2d38385e7a9969c2abe45d22e), 'block_head'), 'body' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_body'), 'summary' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_summary'), 'panel' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_panel'), 'toolbar' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_toolbar'), 'menu' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_menu'), 'queries' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_queries')))
in Template.php line 184
at Template->displayBlock('panel', array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2, 'app' => object(AppVariable), 'frontend_url' => 'https://localhost:3030'), array('head' => array(object(__TwigTemplate_13ffe3535b5555273d03e7839e3646a5b2ed30b2d38385e7a9969c2abe45d22e), 'block_head'), 'body' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_body'), 'summary' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_summary'), 'panel' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_panel'), 'toolbar' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_toolbar'), 'menu' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_menu'), 'queries' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_queries')))
in b6cfb3d63c75d5504532842b19f7f9f6f0f5618fa47aa77842a1f74b411c6960.php line 214
at __TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430->block_body(array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2, 'app' => object(AppVariable), 'frontend_url' => 'https://localhost:3030'), array('head' => array(object(__TwigTemplate_13ffe3535b5555273d03e7839e3646a5b2ed30b2d38385e7a9969c2abe45d22e), 'block_head'), 'body' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_body'), 'summary' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_summary'), 'panel' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_panel'), 'toolbar' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_toolbar'), 'menu' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_menu'), 'queries' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_queries')))
in Template.php line 184
at Template->displayBlock('body', array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2, 'app' => object(AppVariable), 'frontend_url' => 'https://localhost:3030'), array('head' => array(object(__TwigTemplate_13ffe3535b5555273d03e7839e3646a5b2ed30b2d38385e7a9969c2abe45d22e), 'block_head'), 'body' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_body'), 'summary' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_summary'), 'panel' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_panel'), 'toolbar' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_toolbar'), 'menu' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_menu'), 'queries' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_queries')))
in 23bc772cec6d8259b8fd6b22f608ddeb310ed48987beb7ad398a382ce2572275.php line 69
at __TwigTemplate_13ffe3535b5555273d03e7839e3646a5b2ed30b2d38385e7a9969c2abe45d22e->doDisplay(array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2, 'app' => object(AppVariable), 'frontend_url' => 'https://localhost:3030'), array('head' => array(object(__TwigTemplate_13ffe3535b5555273d03e7839e3646a5b2ed30b2d38385e7a9969c2abe45d22e), 'block_head'), 'body' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_body'), 'summary' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_summary'), 'panel' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_panel'), 'toolbar' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_toolbar'), 'menu' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_menu'), 'queries' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_queries')))
in Template.php line 407
at Template->displayWithErrorHandling(array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2, 'app' => object(AppVariable), 'frontend_url' => 'https://localhost:3030'), array('head' => array(object(__TwigTemplate_13ffe3535b5555273d03e7839e3646a5b2ed30b2d38385e7a9969c2abe45d22e), 'block_head'), 'body' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_body'), 'summary' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_summary'), 'panel' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_panel'), 'toolbar' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_toolbar'), 'menu' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_menu'), 'queries' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_queries')))
in Template.php line 380
at Template->display(array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2, 'app' => object(AppVariable), 'frontend_url' => 'https://localhost:3030'), array('body' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_body'), 'summary' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_summary'), 'panel' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_panel'), 'toolbar' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_toolbar'), 'menu' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_menu'), 'queries' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_queries')))
in b6cfb3d63c75d5504532842b19f7f9f6f0f5618fa47aa77842a1f74b411c6960.php line 50
at __TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430->doDisplay(array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2, 'app' => object(AppVariable), 'frontend_url' => 'https://localhost:3030'), array('body' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_body'), 'summary' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_summary'), 'panel' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_panel'), 'toolbar' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_toolbar'), 'menu' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_menu'), 'queries' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_queries')))
in Template.php line 407
at Template->displayWithErrorHandling(array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2, 'app' => object(AppVariable), 'frontend_url' => 'https://localhost:3030'), array('body' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_body'), 'summary' => array(object(__TwigTemplate_0c7a41575ddfd52a8b5e89eb552e0681d4e666fb9cb9a7814ac3e88330768430), 'block_summary'), 'panel' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_panel'), 'toolbar' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_toolbar'), 'menu' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_menu'), 'queries' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_queries')))
in Template.php line 380
at Template->display(array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2, 'app' => object(AppVariable), 'frontend_url' => 'https://localhost:3030'), array('toolbar' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_toolbar'), 'menu' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_menu'), 'panel' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_panel'), 'queries' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_queries')))
in 79a9aff25a9aa7e151c8edfe233223a7c9205d704571736e49edc2e106ad36a9.php line 53
at __TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d->doDisplay(array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2, 'app' => object(AppVariable), 'frontend_url' => 'https://localhost:3030'), array('toolbar' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_toolbar'), 'menu' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_menu'), 'panel' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_panel'), 'queries' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_queries')))
in Template.php line 407
at Template->displayWithErrorHandling(array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2, 'app' => object(AppVariable), 'frontend_url' => 'https://localhost:3030'), array('toolbar' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_toolbar'), 'menu' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_menu'), 'panel' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_panel'), 'queries' => array(object(__TwigTemplate_5353bf2b5a91baf26d4ee5fa4d4af92e87dc6f881f7320edc6718130ebbc305d), 'block_queries')))
in Template.php line 380
at Template->display(array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2))
in Template.php line 392
at Template->render(array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2), array())
in TemplateWrapper.php line 45
at TemplateWrapper->render(array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2))
in Environment.php line 318
at Environment->render('@Doctrine/Collector/db.html.twig', array('token' => '114c47', 'profile' => object(Profile), 'collector' => object(DoctrineDataCollector), 'panel' => 'db', 'page' => 'explain', 'request' => object(Request), 'templates' => array('request' => '@WebProfiler/Collector/request.html.twig', 'api_platform.data_collector.request' => '@ApiPlatform/DataCollector/request.html.twig', 'time' => '@WebProfiler/Collector/time.html.twig', 'memory' => '@WebProfiler/Collector/memory.html.twig', 'validator' => '@WebProfiler/Collector/validator.html.twig', 'ajax' => '@WebProfiler/Collector/ajax.html.twig', 'form' => '@WebProfiler/Collector/form.html.twig', 'exception' => '@WebProfiler/Collector/exception.html.twig', 'logger' => '@WebProfiler/Collector/logger.html.twig', 'events' => '@WebProfiler/Collector/events.html.twig', 'router' => '@WebProfiler/Collector/router.html.twig', 'cache' => '@WebProfiler/Collector/cache.html.twig', 'translation' => '@WebProfiler/Collector/translation.html.twig', 'security' => '@Security/Collector/security.html.twig', 'twig' => '@WebProfiler/Collector/twig.html.twig', 'db' => '@Doctrine/Collector/db.html.twig', 'swiftmailer' => '@Swiftmailer/Collector/swiftmailer.html.twig', 'dump' => '@Debug/Profiler/dump.html.twig', 'messenger' => '@WebProfiler/Collector/messenger.html.twig', 'vich_uploader.mapping_collector' => '@VichUploader/Collector/mapping_collector.html.twig', 'elastica' => '@FOSElastica/Collector/elastica.html.twig', 'config' => '@WebProfiler/Collector/config.html.twig'), 'is_ajax' => false, 'profiler_markup_version' => 2))
in ProfilerController.php line 104
at ProfilerController->panelAction(object(Request), '114c47')
in HttpKernel.php line 151
at HttpKernel->handleRaw(object(Request), 1)
in HttpKernel.php line 68
at HttpKernel->handle(object(Request), 1, true)
in Kernel.php line 198
at Kernel->handle(object(Request))
in index.php line 25

@greg0ire
Copy link
Member

Ok so if I understand correctly, the data comes from an HTTP request, which probably should have more data. Can you have look at the POST/GET data and the body of the request that fails?

@norkunas
Copy link
Contributor Author

norkunas commented Jun 25, 2019

That's a GET request when clicking on explain.

:authority: p.local
:method: GET
:path: /_profiler/a3eb1e?panel=db&page=explain&connection=default&query=2
:scheme: https
accept: */*
accept-encoding: gzip, deflate, br
accept-language: lt-LT,lt;q=0.9,en-US;q=0.8,en;q=0.7
cache-control: no-cache
cookie: PHPSESSID=ekrkldqt2fmuprsgkkvhctl7iu
dnt: 1
pragma: no-cache
referer: https://p.local/_profiler/a3eb1e?panel=db
user-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36
x-requested-with: XMLHttpRequest

@greg0ire
Copy link
Member

Oh query is just an integer, and it looks like I misread, queries come from $profile->getCollector('db')->getQueries(). That's probably the piece of code you should investigate, because it should return an array of queries that should all have a types key, right?

@norkunas
Copy link
Contributor Author

Yes, so fix should go to symfony bridge then, i'll make a new PR.

@norkunas norkunas closed this Jun 25, 2019
@norkunas
Copy link
Contributor Author

Looking deeper I found that DBAL DebugStack logger has this:
public function startQuery($sql, ?array $params = null, ?array $types = null)

@greg0ire
Copy link
Member

🤔 weird… public function startQuery($sql, array $params = [], array $types = []) would seem like a much more suitable signature for this…

@norkunas
Copy link
Contributor Author

I thought the same. What should we do? 🙂

@greg0ire
Copy link
Member

We should determine what's the earliest place where we can use an empty array without breaking things. Changing that signature would be a BC-break, so that will not be it, but maybe checks could be added in that function to change null values into arrays. Once this is done, we should consider changing the signature on a branch that accepts BC-breaks (master?)

@norkunas
Copy link
Contributor Author

https://github.com/symfony/symfony/blob/4.4/src/Symfony/Bridge/Doctrine/DataCollector/DoctrineDataCollector.php#L141 I think this should be the place as there is params normalization

@greg0ire
Copy link
Member

I agree, this looks like a good place to do this!

fabpot added a commit to symfony/symfony that referenced this pull request Jun 26, 2019
This PR was merged into the 3.4 branch.

Discussion
----------

[DoctrineBridge] Fix type error

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | - <!-- required for new features -->

See discussion here: doctrine/DoctrineBundle#984

> Having SET sql_mode=(SELECT REPLACE(@@sql_mode, 'ONLY_FULL_GROUP_BY', '')) query and when clicking on explain currently it throws:

> Argument 2 passed to Doctrine\DBAL\Connection::resolveParams() must be of the type array, null given, called in /vendor/doctrine/dbal/lib/Doctrine/DBAL/Connection.php on line 911

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against branch 4.4.
 - Legacy code removals go to the master branch.
-->

Commits
-------

7b8ee3e Fix type error
@norkunas norkunas deleted the fix-type-error branch July 18, 2019 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants