fix: Improve membership inference for flow types

jfirebaugh · jfirebaugh · commit 22469f32d725 · 2018-02-20T17:30:35.000-08:00
diff --git a/__tests__/lib/infer/membership.js b/__tests__/lib/infer/membership.js
@@ -633,3 +633,37 @@ test('inferMembership - export', function() {
     scope: 'instance'
   });
 });
+
+test('inferMembership - flow interface', function() {
+  expect(
+    pick(
+      evaluate(`
+        interface Foo {
+          /** Test */
+          bar: number
+        }
+      `)[0],
+      ['memberof', 'scope']
+    )
+  ).toEqual({
+    memberof: 'Foo',
+    scope: 'instance'
+  });
+});
+
+test('inferMembership - flow object type alias', function() {
+  expect(
+    pick(
+      evaluate(`
+        type Foo = {
+          /** Test */
+          bar: number
+        }
+      `)[0],
+      ['memberof', 'scope']
+    )
+  ).toEqual({
+    memberof: 'Foo',
+    scope: 'instance'
+  });
+});
diff --git a/src/infer/membership.js b/src/infer/membership.js
@@ -397,6 +397,21 @@ module.exports = function() {
       }
     }
 
+    // type Foo = { bar: T }
+    // interface Foo { bar: T }
+    if (
+      path.isObjectTypeProperty() &&
+      path.parentPath.isObjectTypeAnnotation() &&
+      (path.parentPath.parentPath.isTypeAlias() ||
+        path.parentPath.parentPath.isInterfaceDeclaration())
+    ) {
+      return inferMembershipFromIdentifiers(
+        comment,
+        [path.parentPath.parentPath.get('id').node.name],
+        'instance'
+      );
+    }
+
     return comment;
   };
 };
