Fix width calculation for multiline cells

larsbutler · larsbutler · commit 53ac1a7c7fcd · 2017-09-12T17:22:02.000+02:00
Use correct padding to fix the issue. This wasn't a problem for "grid" table formatting, but it was an issue for "simple". It seems that the root cause was a hard-coded pad value of 1 (see commit a93034a, tabulate.py line 1336).
diff --git a/tabulate.py b/tabulate.py
@@ -1333,7 +1333,7 @@ def _append_multiline_row(lines, padded_multiline_cells, padded_widths, colalign
     cells_lines = [(cl + [' '*w]*(nlines - len(cl))) for cl, w in zip(cells_lines, colwidths)]
     lines_cells = [[cl[i] for cl in cells_lines] for i in range(nlines)]
     for ln in lines_cells:
-        padded_ln = _pad_row(ln, 1)
+        padded_ln = _pad_row(ln, pad)
         _append_basic_row(lines, padded_ln, colwidths, colaligns, rowfmt)
     return lines
 
diff --git a/test/test_output.py b/test/test_output.py
@@ -44,6 +44,21 @@ def test_simple():
     assert_equal(expected, result)
 
 
+def test_simple_multiline():
+    "Output: simple with multiline cells"
+    expected = "\n".join([
+        " key     value",
+        "-----  ---------",
+        " foo      bar",
+        "spam   multiline",
+        "         world",
+    ])
+    table = [["key", "value"], ["foo", "bar"], ["spam", "multiline\nworld"]]
+    result = tabulate(table, headers='firstrow', stralign="center",
+                      tablefmt="simple")
+    assert_equal(expected, result)
+
+
 def test_simple_headerless():
     "Output: simple without headers"
     expected = "\n".join(['----  --------',
