Skip to content

Update build docs for Windows #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Update build docs for Windows #121

wants to merge 3 commits into from

Conversation

DamianSuess
Copy link

@DamianSuess DamianSuess commented Jul 24, 2023 •
edited
Loading

The Building.md file was initially made for Ubuntu 20.04, however, I should have expanded it for Windows as well.

Feature includes:

  • Updated readme.md markdown formatting
  • Building.md - Added Building for Windows
  • WinBuild.bat - Added VS2022 and echo output for stages

Build Failures

Currently, out-the-gate on Win10 when branched off of main:

  • MSBuild v17: 1328 Warning(s) and 77 Error(s)
  • MSBuild v15: ...

The most reoccurring error that flashes is the following, as well as A LOT of other "downgrade" issues.

 NU1102: Unable to find package Microsoft.VisualStudio.CodingConventions with version (>= 1.1.20230104.5)
  - Found 1 version(s) in dotnet-tools [ Nearest version: 1.1.20180503.2 ]

Looking into the other open PRs and any undocumented dependencies.

Linked Issues

@DamianSuess DamianSuess marked this pull request as draft July 24, 2023 16:28
@DamianSuess DamianSuess mentioned this pull request Jul 24, 2023
Open
@MakiWolf
Copy link

The most reoccurring error that flashes is

 NU1102: Unable to find package Microsoft.VisualStudio.CodingConventions with version (>= 1.1.20230104.5)
  - Found 1 version(s) in dotnet-tools [ Nearest version: 1.1.20180503.2 ]

@DamianSuess
Does this error happen on the PR where Microsoft.VisualStudio.CodingConventions has been removed also? #120

And also which msbuild do you use?
https://github.com/mono/msbuild (old mono fork from original msbuild) or https://github.com/dotnet/msbuild

@lextm
Copy link

lextm commented Jul 25, 2023

You should also update the GitHub Actions manifest in this PR if possible, https://github.com/dotdevelop/dotdevelop/blob/main/.github/workflows/monodevelop.yml

@DamianSuess
Copy link
Author

DamianSuess commented Jul 25, 2023 •
edited
Loading

Does this error happen on the PR where Microsoft.VisualStudio.CodingConventions has been removed also? #120

@MakiWolf, good call, that's gonna be my next move. Getting this to build on Windows is definitely going to take a while to get moving. I really appreciate the help, folks :)

Thanks, @lextm, for the reminder. As soon as I get something to build, that will be updated

@MakiWolf MakiWolf mentioned this pull request Oct 28, 2023
Open
@MakiWolf
Copy link

This line links to the windows nuget packages

dotdevelop/main/Directory.Build.props

Line 10 in ce0af42

<ReferencesVSEditor Condition=" '$(OS)' == 'Windows_NT' ">$(RootDirectory)\msbuild\ReferencesVSEditor.Windows.props</ReferencesVSEditor>

Maybe here we should make a replace which builds the nuget packages from vs editor api from source directly like we do on Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DamianSuess @MakiWolf @lextm