Skip to content

Mdoc 5.9.2.1 release #8827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 7, 2023
Merged

Mdoc 5.9.2.1 release #8827

merged 3 commits into from
Feb 7, 2023

Conversation

huangmin-ms
Copy link
Contributor

@huangmin-ms huangmin-ms commented Feb 3, 2023 •
edited
Loading

VSC-Service-Account added 2 commits February 3, 2023 07:29
@ghost ghost assigned huangmin-ms Feb 3, 2023
@ghost ghost added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Feb 3, 2023
@learn-build-service-prod

This comment was marked as outdated.

Sign in to view
@huangmin-ms huangmin-ms requested a review from gewarren February 6, 2023 02:10
gewarren
gewarren approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than the one area of data loss.

@huangmin-ms huangmin-ms marked this pull request as ready for review February 7, 2023 02:40
@learn-build-service-prod
Copy link

Learn Build status updates of commit 4c891c4:

💡 Validation status: suggestions

File Status Preview URL Details
xml/System.Numerics/Complex.xml 💡Suggestion View Details
xml/System/Decimal.xml 💡Suggestion View Details
xml/System/Double.xml 💡Suggestion View Details
xml/System/Half.xml 💡Suggestion View Details
xml/System/Int128.xml 💡Suggestion View Details
xml/System/Single.xml 💡Suggestion View Details
xml/System/UInt128.xml 💡Suggestion View Details
xml/Microsoft.CSharp/CSharpCodeProvider.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging.AzureAppServices.Internal/BlobAppendReferenceWrapper.xml ✅Succeeded View
xml/Microsoft.VisualBasic/VBCodeProvider.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeX509ChainHandle.xml ✅Succeeded View
xml/Microsoft.Win32/SystemEvents.xml ✅Succeeded View
xml/System.CodeDom.Compiler/CodeCompiler.xml ✅Succeeded View
xml/System.Configuration/ApplicationSettingsBase.xml ✅Succeeded View
xml/System.Configuration/LocalFileSettingsProvider.xml ✅Succeeded View
xml/System.Configuration/SettingValueElement.xml ✅Succeeded View
xml/System.Data.EntityClient/EntityParameter.xml ✅Succeeded View
xml/System.Diagnostics/CounterSampleCalculator.xml ✅Succeeded View
xml/System.Diagnostics/DefaultTraceListener.xml ✅Succeeded View
xml/System.Diagnostics/EventLog.xml ✅Succeeded View
xml/System.Diagnostics/EventLogEntry.xml ✅Succeeded View
xml/System.Diagnostics/PerformanceCounter.xml ✅Succeeded View
xml/System.Diagnostics/PerformanceCounterCategory.xml ✅Succeeded View
xml/System.Diagnostics/PerformanceCounterManager.xml ✅Succeeded View
xml/System.Diagnostics/Process.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System.Numerics/Complex.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Decrement(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_Increment(System.Numerics.Complex).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Numerics.Complex.op_UnaryPlus(System.Numerics.Complex).

xml/System/Decimal.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Decrement(System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Division(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Equality(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_GreaterThan(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_GreaterThanOrEqual(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Increment(System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Inequality(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_LessThan(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_LessThanOrEqual(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Modulus(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Multiply(System.Decimal,System.Decimal).

xml/System/Double.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Double.op_Equality(System.Double,System.Double).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Double.op_GreaterThan(System.Double,System.Double).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Double.op_GreaterThanOrEqual(System.Double,System.Double).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Double.op_Inequality(System.Double,System.Double).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Double.op_LessThan(System.Double,System.Double).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Double.op_LessThanOrEqual(System.Double,System.Double).

xml/System/Half.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Half.op_Addition(System.Half,System.Half).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Half.op_Decrement(System.Half).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Half.op_Division(System.Half,System.Half).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Half.op_Equality(System.Half,System.Half).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Half.op_GreaterThan(System.Half,System.Half).

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren gewarren merged commit 2b9e9bc into main Feb 7, 2023
@gewarren gewarren deleted the mh/mdoc-5.9.2.1-v5 branch February 7, 2023 16:57
@gewarren gewarren mentioned this pull request Feb 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

@Rick-Anderson Rick-Anderson Awaiting requested review from Rick-Anderson Rick-Anderson is a code owner

@HongGit HongGit Awaiting requested review from HongGit HongGit is a code owner

@mconnew mconnew Awaiting requested review from mconnew mconnew is a code owner

@AaronRobinsonMSFT AaronRobinsonMSFT Awaiting requested review from AaronRobinsonMSFT AaronRobinsonMSFT is a code owner

@jkoritzinsky jkoritzinsky Awaiting requested review from jkoritzinsky jkoritzinsky is a code owner

@ajcvickers ajcvickers Awaiting requested review from ajcvickers

@David-Engel David-Engel Awaiting requested review from David-Engel

@JRahnama JRahnama Awaiting requested review from JRahnama

@cston cston Awaiting requested review from cston cston is a code owner

@333fred 333fred Awaiting requested review from 333fred 333fred is a code owner

Assignees

@huangmin-ms huangmin-ms

Labels
area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huangmin-ms @gewarren