Merge pull request #569 from atifaziz/accept-encoding-gzip

filipw · web-flow · commit 4c4f188468d1 · 2020-11-02T16:36:07.000+01:00
Accept content-encoding of "gzip" for remote scripts
diff --git a/src/Dotnet.Script.Core/ScriptDownloader.cs b/src/Dotnet.Script.Core/ScriptDownloader.cs
@@ -1,6 +1,7 @@
 ﻿using System;
 using System.IO;
 using System.IO.Compression;
+using System.Net;
 using System.Net.Http;
 using System.Threading.Tasks;
 
@@ -10,7 +11,12 @@ public class ScriptDownloader
     {
         public async Task<string> Download(string uri)
         {
-            using (HttpClient client = new HttpClient())
+            using (HttpClient client = new HttpClient(new HttpClientHandler
+            {
+                // Avoid Deflate due to bugs. For more info, see:
+                // https://github.com/weblinq/WebLinq/issues/132
+                AutomaticDecompression = DecompressionMethods.GZip
+            }))
             {
                 using (HttpResponseMessage response = await client.GetAsync(uri, HttpCompletionOption.ResponseHeadersRead))
                 {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`using System;`
`2`	`2`	`using System.IO;`
`3`	`3`	`using System.IO.Compression;`
	`4`	`+using System.Net;`
`4`	`5`	`using System.Net.Http;`
`5`	`6`	`using System.Threading.Tasks;`
`6`	`7`
`@@ -10,7 +11,12 @@ public class ScriptDownloader`
`10`	`11`	`{`
`11`	`12`	`public async Task<string> Download(string uri)`
`12`	`13`	`{`
`13`		`- using (HttpClient client = new HttpClient())`
	`14`	`+ using (HttpClient client = new HttpClient(new HttpClientHandler`
	`15`	`+ {`
	`16`	`+ // Avoid Deflate due to bugs. For more info, see:`
	`17`	`+ // https://github.com/weblinq/WebLinq/issues/132`
	`18`	`+ AutomaticDecompression = DecompressionMethods.GZip`
	`19`	`+ }))`
`14`	`20`	`{`
`15`	`21`	`using (HttpResponseMessage response = await client.GetAsync(uri, HttpCompletionOption.ResponseHeadersRead))`
`16`	`22`	`{`