Merge pull request #478 from filipw/bugfix/issue477

filipw · web-flow · commit c0711d4ba452 · 2019-08-02T15:52:52.000+02:00
Handle version number with more than 3 subparts
diff --git a/src/Dotnet.Script.DependencyModel/ProjectSystem/PackageVersion.cs b/src/Dotnet.Script.DependencyModel/ProjectSystem/PackageVersion.cs
@@ -8,7 +8,7 @@ namespace Dotnet.Script.DependencyModel.ProjectSystem
     /// </summary>
     public class PackageVersion : IEquatable<PackageVersion>
     {
-        private static Regex IsPinnedRegex = new Regex(@"^(?>\[\d+[^,\]]+(?<!\.)\]|\d+\.\d+\.\d+)$", RegexOptions.Compiled);
+        private static Regex IsPinnedRegex = new Regex(@"^(?>\[\d+[^,\]]+(?<!\.)\]|\d+(\.\d+){2,})$", RegexOptions.Compiled);
 
         /// <summary>
         /// Initializes a new instance of the <see cref="PackageVersion"/> class.
@@ -29,7 +29,7 @@ public PackageVersion(string version)
         /// <summary>
         /// Gets a <see cref="bool"/> value that indicates whether the <see cref="PackageVersion"/> is "pinned".
         /// </summary>
-        public bool IsPinned {get;}
+        public bool IsPinned { get; }
 
         /// <inheritdoc/>
         public bool Equals(PackageVersion other)
diff --git a/src/Dotnet.Script.Tests/PackageVersionTests.cs b/src/Dotnet.Script.Tests/PackageVersionTests.cs
@@ -11,6 +11,7 @@ public class PackageVersionTests
     {
         [Theory]
         [InlineData("1.2.3")]
+        [InlineData("1.2.3.4")]
         [InlineData("[1.2]")]
         [InlineData("[1.2.3]")]
         [InlineData("[1.2.3-beta1]")]

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@ public class PackageVersionTests`
`11`	`11`	`{`
`12`	`12`	`[Theory]`
`13`	`13`	`[InlineData("1.2.3")]`
	`14`	`+ [InlineData("1.2.3.4")]`
`14`	`15`	`[InlineData("[1.2]")]`
`15`	`16`	`[InlineData("[1.2.3]")]`
`16`	`17`	`[InlineData("[1.2.3-beta1]")]`