Skip to content

Prerelease nuget packages #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
b0urb4k1 opened this issue Jan 8, 2019 · 9 comments
Closed

Prerelease nuget packages #407

b0urb4k1 opened this issue Jan 8, 2019 · 9 comments
Labels
bug

Comments

@b0urb4k1
Copy link

b0urb4k1 commented Jan 8, 2019

The NugetReferenceResolver only resolves normal packages but not prerelease packages.

https://github.com/filipw/dotnet-script/blob/master/src/Dotnet.Script.DependencyModel.Nuget/NuGetSourceReferenceResolver.cs#L18
@filipw
Copy link
Member

filipw commented Jan 9, 2019

So it works at runtime, but you don't get intellisense correctly, right?

@filipw filipw added the bug label Jan 9, 2019
@b0urb4k1
Copy link
Author

b0urb4k1 commented Jan 9, 2019

Intellisense seems to work but caching the package does not work and you get the message that you have to pin the version.

@seesharper
Copy link
Collaborator

seesharper commented Jan 15, 2019 •
edited
Loading

This should use the same regex as

https://github.com/filipw/dotnet-script/blob/cf01f703499220b3bc48ef329d3458dccb4af40f/src/Dotnet.Script.DependencyModel/ProjectSystem/ScriptParser.cs#L67-L74

@seesharper
Copy link
Collaborator

@b0urb4k1 Could you give an example of a preview package that does not get cached?

@jbtule
Copy link

jbtule commented Dec 9, 2019 •
edited
Loading

Here is an example. Octokit.GraphQL.
#r "nuget: Octokit.GraphQL, 0.1.4-beta"

https://www.nuget.org/packages/Octokit.GraphQL/0.1.4-beta

warn: Dotnet.Script.Core.Commands.ExecuteScriptCommand[0]
      The script /.../github-create-release.csx is not cacheable. For caching and optimal performance, ensure that the script only contains NuGet references with pinned/exact versions.
warn: Dotnet.Script.DependencyModel.Context.CachedRestorer[0]
      Unable to cache /tmp/scripts/.../netcoreapp3.1/script.csproj. For caching and optimal performance, ensure that the script(s) references Nuget packages with a pinned version.

Seems similar to #477

@KyleMit
Copy link

KyleMit commented May 19, 2020

Another Example...

Microsoft.Data.SqlClient 2.0.0-preview3.20122.2:

#r "nuget: Microsoft.Data.SqlClient,2.0.0-preview3.20122.2"

Returns:

warn: Dotnet.Script.Core.Commands.ExecuteScriptCommand[0]
      The script C:\repos\code\sql-search\sqlsearch.csx is not cacheable. For caching and optimal performance, ensure that the script only contains NuGet references with pinned/exact versions.  
warn: Dotnet.Script.DependencyModel.Context.CachedRestorer[0]
      Unable to cache C:\Users\kylemit\AppData\Local\Temp\dotnet-script\C\repos\code\sql-search\netcoreapp3.1\script.csproj. For caching and optimal performance, ensure that the script(s) 
references Nuget packages with a pinned version.

@atifaziz atifaziz mentioned this issue Jun 4, 2020
Merged
@atifaziz
Copy link
Contributor

atifaziz commented Jun 5, 2020

@filipw Thanks for merging #544. I guess we can consider this closed via de064b9?

@arphox
Copy link

arphox commented Jun 12, 2024 •
edited
Loading

In the 1.5.0 version of dotnet-script, I was able to resolve a directly targeted version of a pre-release nuget package:
#r "nuget: MyPackage, 0.0.1-alpha-1"

@filipw
Copy link
Member

filipw commented Jun 13, 2024

yes - thanks

@filipw filipw closed this as completed Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@atifaziz @jbtule @seesharper @filipw @b0urb4k1 @KyleMit @arphox