Recognize pinned pre-release package references #544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #407 by fixing the regular expression used to determine whether a package reference is pinned or not.
Steps to Test
Before this PR, using the latest version (0.52.0), the following:
would issue the warning:
After checking out this PR's branch, the following:
will issue no warning about non-cache-ability of a floating (or an unpinned) reference.
Additional Notes
This PR also refactored parts to share the regular expressions for package references more consistently between
ScriptParser
andNuGetSourceReferenceResolver
. Since these two reside in separate projects, I avoided a dependency between the two by renderingScriptParser
partial, moving shared parts to another partial definition of the same class in a separate file calledScriptParserInternals.cs
, and finally linking that into the Dotnet.Script.DependencyModel.NuGet project. The partial definition inScriptParserInternals.cs
has nopublic
modifier soScriptParser
will not get introduced into the public API of Dotnet.Script.DependencyModel.NuGet.