Skip to content

Request timeout (%s) must be larger than session timeout (%s) [1.4.5] #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isamaru opened this issue Mar 20, 2019 · 1 comment
Closed
Labels

Comments

@isamaru
Copy link
Contributor

isamaru commented Mar 20, 2019

In 1.4.5, session_timeout acts as a lower bound for request_timeout.

This seems excessively strict. If we use a short timeout like 2s, the heartbeat thread could simply retry, there seems to be some logic already in for that.

In the current implementation, I found these blockers:

  • check of arguments
  • timeout of heartbeat request makes the coordinator dead. We could remove this for heartbeat thread.
  • remove timed-out in-flight-requests from appropriate collections on timeout
  • allow receiving responses out of order (Correlation IDs do not match [1.4.5] #1748)

If we clear these, I think we should allow short request_timeouts.

My goal is to allow better recovery with unstable connections (which do occassionally occur in our environment)

@dpkp what do you think?

@jeffwidman
Copy link
Contributor

This has been true a lot longer than 1.4.5, as it was added years ago in 432f00e#diff-9da855eb60eed8ecc72ce217c25e576cR275.

@dpkp dpkp added the consumer label Mar 18, 2025
@dpkp dpkp closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants