Nice to have: context managers #2601

johnkntran · 2025-04-29T11:14:41Z

Would be nice to be able to use a with statement to close the connections:

with KafkaProducer(...) as producer:
    producer.send(...)

Instead of try/finally:

producer = KafkaProducer(...)
try:
    producer.send(...)
finally:
    producer.close()

Just add this code to KafkaProducer, KafkaConsumer, KafkaClient, KafkaAdminClient:

    def __enter__(self):
        return self

    def __exit__(self, exc_type, exc_value, traceback):
        self.close()

I tried to push a PR for you to save the trouble, but was denied.

The text was updated successfully, but these errors were encountered:

dpkp · 2025-04-29T15:46:27Z

protip:

from contextlib import closing

with closing(KafkaProducer(...)) as producer:
    producer.send(...)

dpkp closed this as completed Apr 29, 2025

Provide feedback