Only call destroy on a client when it is not already being destroyed

joskuijpers · joskuijpers · commit 1c171773697f · 2014-07-30T14:17:04.000+02:00
Adds a check in the error listener on the client in the pool, to
prevent calling destroy on a client when it is already being
destroyed.
Without this check, if an error occurs during the ending of the
stream, such as a timeout, the client is never removed from
the pool and weird things happen.
diff --git a/lib/pool.js b/lib/pool.js
@@ -30,7 +30,13 @@ var pools = {
           //via the pg object and then removing errored client from the pool
           client.on('error', function(e) {
             pool.emit('error', e, client);
-            pool.destroy(client);
+
+            // If the client is already being destroyed, the error
+            // occurred during stream ending. Do not attempt to destroy
+            // the client again.
+            if (!client._destroying) {
+              pool.destroy(client);
+            }
           });
 
           // Remove connection from pool on disconnect
