fix: restore visibility of tool execution output

bhouston · bhouston · commit 0809694538d8 · 2025-03-18T17:22:27.000-04:00
The CLI was no longer showing tool execution output by default. This change: 1. Fixed the logger's emitMessages method to properly respect log level 2. Changed the default log level to 'log' in the configuration 3. Updated tool execution logs to use info level instead of log level Fixes #328
diff --git a/issue_content.md b/issue_content.md
diff --git a/packages/agent/src/core/executeToolCall.ts b/packages/agent/src/core/executeToolCall.ts
@@ -73,9 +73,9 @@ export const executeToolCall = async (
   if (tool.logParameters) {
     tool.logParameters(validatedJson, toolContext);
   } else {
-    logger.log('Parameters:');
+    logger.info('Parameters:');
     Object.entries(validatedJson).forEach(([name, value]) => {
-      logger.log(`  - ${name}: ${JSON.stringify(value).substring(0, 60)}`);
+      logger.info(`  - ${name}: ${JSON.stringify(value).substring(0, 60)}`);
     });
   }
 
@@ -103,12 +103,12 @@ export const executeToolCall = async (
   if (tool.logReturns) {
     tool.logReturns(output, toolContext);
   } else {
-    logger.log('Results:');
+    logger.info('Results:');
     if (typeof output === 'string') {
-      logger.log(`  - ${output}`);
+      logger.info(`  - ${output}`);
     } else if (typeof output === 'object') {
       Object.entries(output).forEach(([name, value]) => {
-        logger.log(`  - ${name}: ${JSON.stringify(value).substring(0, 60)}`);
+        logger.info(`  - ${name}: ${JSON.stringify(value).substring(0, 60)}`);
       });
     }
   }
diff --git a/packages/agent/src/core/toolAgent/toolAgentCore.ts b/packages/agent/src/core/toolAgent/toolAgentCore.ts
@@ -102,7 +102,7 @@ export const toolAgent = async (
         
         // Add each message to the conversation
         for (const message of pendingUserMessages) {
-          logger.log(`Message from user: ${message}`);
+          logger.info(`Message from user: ${message}`);
           messages.push({
             role: 'user',
             content: `[Correction from user]: ${message}`,
diff --git a/packages/agent/src/core/toolAgent/toolExecutor.ts b/packages/agent/src/core/toolAgent/toolExecutor.ts
@@ -37,7 +37,7 @@ export async function executeTools(
 
   const { logger } = context;
 
-  logger.debug(`Executing ${toolCalls.length} tool calls`);
+  logger.info(`Executing ${toolCalls.length} tool calls`);
 
   const toolResults = await Promise.all(
     toolCalls.map(async (call) => {
diff --git a/packages/agent/src/utils/interactiveInput.ts b/packages/agent/src/utils/interactiveInput.ts
@@ -24,7 +24,11 @@ class OutputInterceptor extends Writable {
     this.paused = false;
   }
 
-  _write(chunk: Buffer | string, encoding: BufferEncoding, callback: (error?: Error | null) => void): void {
+  _write(
+    chunk: Buffer | string,
+    encoding: BufferEncoding,
+    callback: (error?: Error | null) => void,
+  ): void {
     if (!this.paused) {
       this.originalStdout.write(chunk, encoding);
     }
@@ -36,83 +40,92 @@ class OutputInterceptor extends Writable {
 export const initInteractiveInput = () => {
   // Save original stdout
   const originalStdout = process.stdout;
-  
+
   // Create interceptor
   const interceptor = new OutputInterceptor(originalStdout);
-  
+
   // Replace stdout with our interceptor
   // @ts-expect-error - This is a hack to replace stdout
   process.stdout = interceptor;
-  
+
   // Create readline interface for listening to key presses
   const rl = readline.createInterface({
     input: process.stdin,
     output: interceptor,
     terminal: true,
   });
-  
+
   // Close the interface to avoid keeping the process alive
   rl.close();
-  
+
   // Listen for keypress events
   readline.emitKeypressEvents(process.stdin);
   if (process.stdin.isTTY) {
     process.stdin.setRawMode(true);
   }
-  
+
   process.stdin.on('keypress', async (str, key) => {
     // Check for Ctrl+C to exit
     if (key.ctrl && key.name === 'c') {
       process.exit(0);
     }
-    
+
     // Check for Ctrl+M to enter message mode
     if (key.ctrl && key.name === 'm') {
       // Pause output
       interceptor.pause();
-      
+
       // Create a readline interface for input
       const inputRl = createInterface({
         input: process.stdin,
         output: originalStdout,
       });
-      
+
       try {
         // Reset cursor position and clear line
         originalStdout.write('\r\n');
-        originalStdout.write(chalk.green('Enter correction or additional context (Ctrl+C to cancel):\n') + '> ');
-        
+        originalStdout.write(
+          chalk.green(
+            'Enter correction or additional context (Ctrl+C to cancel):\n',
+          ) + '> ',
+        );
+
         // Get user input
         const userInput = await inputRl.question('');
-        
+
         // Add message to queue if not empty
         if (userInput.trim()) {
           userMessages.push(userInput);
-          originalStdout.write(chalk.green('\nMessage sent to agent. Resuming output...\n\n'));
+          originalStdout.write(
+            chalk.green('\nMessage sent to agent. Resuming output...\n\n'),
+          );
         } else {
-          originalStdout.write(chalk.yellow('\nEmpty message not sent. Resuming output...\n\n'));
+          originalStdout.write(
+            chalk.yellow('\nEmpty message not sent. Resuming output...\n\n'),
+          );
         }
       } catch (error) {
-        originalStdout.write(chalk.red(`\nError sending message: ${error}\n\n`));
+        originalStdout.write(
+          chalk.red(`\nError sending message: ${error}\n\n`),
+        );
       } finally {
         // Close input readline interface
         inputRl.close();
-        
+
         // Resume output
         interceptor.resume();
       }
     }
   });
-  
+
   // Return a cleanup function
   return () => {
     // Restore original stdout
-    // @ts-expect-error - This is a hack to restore stdout
     process.stdout = originalStdout;
-    
+
     // Disable raw mode
     if (process.stdin.isTTY) {
       process.stdin.setRawMode(false);
     }
   };
-};
+};
diff --git a/packages/agent/src/utils/logger.ts b/packages/agent/src/utils/logger.ts
@@ -66,7 +66,8 @@ export class Logger {
   }
 
   private emitMessages(level: LogLevel, messages: unknown[]) {
-    if (LogLevel.debug < this.logLevelIndex) return;
+    // Allow all messages at the configured log level or higher
+    if (level < this.logLevelIndex) return;
 
     const lines = messages
       .map((message) =>
diff --git a/packages/cli/src/settings/config.ts b/packages/cli/src/settings/config.ts
@@ -54,7 +54,7 @@ export type Config = {
 
 // Default configuration
 const defaultConfig: Config = {
-  logLevel: 'info',
+  logLevel: 'log',
 
   // GitHub integration
   githubMode: true,

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,8 @@ export class Logger {`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`private emitMessages(level: LogLevel, messages: unknown[]) {`
`69`		`- if (LogLevel.debug < this.logLevelIndex) return;`
	`69`	`+ // Allow all messages at the configured log level or higher`
	`70`	`+ if (level < this.logLevelIndex) return;`
`70`	`71`
`71`	`72`	`const lines = messages`
`72`	`73`	`.map((message) =>`