Skip to content

Fix skipped shell-related tests in agent package #381

Open
@bhouston

Description

@bhouston

Description

Several tests in the packages/agent/src/tools/shell directory have been temporarily skipped due to issues with the test setup. These tests need to be revisited and fixed to ensure proper test coverage.

Affected files

  • packages/agent/src/tools/shell/shellStart.test.ts
  • packages/agent/src/tools/shell/shellStartFix.test.ts
  • packages/agent/src/tools/shell/shellStartBug.test.ts
  • packages/agent/src/tools/shell/shellTrackerIntegration.test.ts

Current workaround

The core functionality of the shell tools has been fixed to properly handle async mode when timeout=0 is specified. The tests have been skipped with appropriate TODO comments to indicate that they need to be fixed in a future update.

Suggested approach

  1. Review the mock setup for each test file
  2. Ensure the mocks properly capture the async behavior
  3. Update the tests to match the current implementation

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions