Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: easy-coding-standard/easy-coding-standard
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 12.2.0
Choose a base ref
...
head repository: easy-coding-standard/easy-coding-standard
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 12.2.1
Choose a head ref
  • 5 commits
  • 3,323 files changed
  • 4 contributors

Commits on May 28, 2024

  1. Update Composer Linting Scripts (#211)

    * build: add composer script aliases to simplify builds
    
    I added a separate `fix-rector` along the lines of `fix-cs` to respect the
    original author's preferred approach. The aliases just make it easy for other
    contributors to run all the tools in the correct order without having to
    look it up.
    
    * build: increased memory limit for PhpStan
    
    The default of 128M was causing consistent crashes for me on Github Codespaces.
    
    Since Rector uses PhpStan in the background, I also upped it's limit. Though
    this really shouldn't matter, since Rector can use the existing cache and
    needs less memory anyway.
    Kenneth-Sills authored May 28, 2024
    Configuration menu
    Copy the full SHA
    ccc480d View commit details
    Browse the repository at this point in the history
  2. Add Gitlab / Code Climate Output Format Support (#210)

    * refactor(formatters): improved discoverability of formatters & their properties
    
    Whether or not a formatter supports progress bars is now encapsulated
    in the formatter class itself, as opposed to being scattered in a couple places
    and relying on maintainers remembering.
    
    Both this progress bar support and the formatter names are also
    implemented as static methods now, whose inclusion can be
    promised by their shared interface.
    
    The console output retains its `::NAME` constant because it needs to be used
    in the default parameters of a configuration constructor (being a default
    setting).
    
    Finally, there remains one hard-coded reference to the `json` output format,
    but only over in the `ListCheckersCommand`. I've left this alone since this
    is not the same type of formatter. Don't want to step on any toes. :)
    
    * feat(formatters): added a Gitlab/Code Climate output formatter
    
    * docs(formatters): added a README section on output formats for clarity
    
    I, personally, didn't realize this tool supported output formatting at first,
    and the existing issues seemed to have been closed without mentioning
    the addition of them. I'd just like to make it more obvious for new users!
    
    * refactor(formatters): ran automated fixers on changed files
    
    * fix(formatters): set gitlab issue severity to 'minor'
    
    My initial line of thinking about setting to 'blocker' was flawed. Not everyone
    uses this tooling the same way and they may want it to show up in the MR
    widget/diffs without _actually_ blocking. Since ECS focuses on code style
    standards instead of correctness issues, this seems an appropriate level.
    
    * refactor(formatters): create separate method to generate report string
    
    This just makes testing easier, as seen in the existing test classes.
    
    * chore: stop linting test fixtures, which may intentionally contain errors
    
    * test(formatters): initial testing for the Gitlab output formatting
    
    This is by no means comprehensive, but it at least confirms it respects
    configurations as expected, formatting is right for trivial cases, and that
    fingerprints are deterministic.
    
    * test(formatters): minor test improvement for Gitlab formatter
    
    - Uncommenting an attribute I disabled for debugging.
    - Added an important clarifying comment.
    
    * test(formatters): fix incorrect paths (and fingerprints) for Gitlab formatter
    
    These should have been relative, but they were absolute. There's no correctness
    issue in the formatter itself, it just repeats the paths it's given. But test
    cases should generally be correct regardless.
    
    ---------
    
    Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
    Kenneth-Sills and TomasVotruba authored May 28, 2024
    Configuration menu
    Copy the full SHA
    ed749cd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d82d8ee View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2024

  1. Configuration menu
    Copy the full SHA
    af9d900 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    095fe59 View commit details
    Browse the repository at this point in the history
Loading