Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: easy-coding-standard/easy-coding-standard
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 12.5.6
Choose a base ref
...
head repository: easy-coding-standard/easy-coding-standard
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 12.5.8
Choose a head ref
  • 7 commits
  • 3,641 files changed
  • 4 contributors

Commits on Jan 31, 2025

  1. Fix: Correctly Apply Symfony Output Flags (#235) 

    * fix: correctly apply Symfony output flags

That is, anything set by `Application::configureIO()` in a "normal"
Symfony Application (we do things a little differently).

Because we construct our styles separately from the application, during
DI initialization, I had to copy the code that handles Symfony's arguments
into here. This isn't an exact copy and paste, but given I did start from their
source and work it into what's committed here, I felt it appropriate to include
their MIT licensing in the NOTICE.

Closes #213

* chore: remove code for unsupported feature

Since the numeric `--verbose` doesn't work with Symfony,
might as well remove the code to handle it.

* Delete NOTICE

---------

Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
    @Kenneth-Sills @TomasVotruba
    Kenneth-Sills and TomasVotruba authored Jan 31, 2025
    Configuration menu
    Copy the full SHA
    7a32b9c View commit details
    Browse the repository at this point in the history

  2. Add Convenience Composer test Script (#227)

    @Kenneth-Sills
    Kenneth-Sills authored Jan 31, 2025
    Configuration menu
    Copy the full SHA
    2fae90d View commit details
    Browse the repository at this point in the history

  3. Stop Reporting Duplicate Errors for Sniffs in the Presence of Fixable… 

    … Changes (#228)

Closes #214

Co-authored-by: Tomas Votruba <tomas.vot@gmail.com>
    @Kenneth-Sills @TomasVotruba
    Kenneth-Sills and TomasVotruba authored Jan 31, 2025
    Configuration menu
    Copy the full SHA
    1f3ac22 View commit details
    Browse the repository at this point in the history

  4. New Feature: Add .editorconfig Support (#259) 

    * fix(phpcs): respect sniffers requesting to be disabled during file processing.

Closes #215

* fix: correct bad syntax from improperly patched commit

* test: add a test case for the new bug fix

* style: fix styling after the wrong auto formatter ran on File.php

* fix: add more duplicate/conflicting checker relationships

Found these while adding EditorConfig support.

This is NOT a breaking change, since this will only make the tool MORE
permissive.

* feat: add initial support for `.editorconfig`

The approach I've gone for puts `.editorconfig` settings above those settings in
the `ecs.php` config itself, to prioritize convenience for those people using
pre-built sets. As many setttings as I could easily implement have been
supported, including one proposed (but not standardized) setting I like to
use.

This commit includes tests, documentation, and dogfooding.

Tests only currently cover the parsing of `.editorconfig`, but do not test
how all permutations affect configuration. Doing so would require advanced
alias mocks of the `EditorConfigFactory` and it's `load` method, which I wasn't
able to get working in an initial attempt. That, or a refactor of
`ECSConfigBuilder` to allow injecting the factory, but I didn't want to mess
with  any of the exposed public API.

Closes #217

* rebase

---------

Co-authored-by: Kenneth Sills <132029135+Kenneth-Sills@users.noreply.github.com>
    @TomasVotruba @Kenneth-Sills
    TomasVotruba and Kenneth-Sills authored Jan 31, 2025
    Configuration menu
    Copy the full SHA
    73135c6 View commit details
    Browse the repository at this point in the history

  5. bump cs fixer

    @TomasVotruba
    TomasVotruba committed Jan 31, 2025
    Configuration menu
    Copy the full SHA
    b814f50 View commit details
    Browse the repository at this point in the history

  6. Fix downgrade error (#260) 

    * Fix downgrade enum

* finalize class

* fix

* add back

* rector

* rectify

* Fix phpstan
    @samsonasik
    samsonasik authored Jan 31, 2025
    Configuration menu
    Copy the full SHA
    1dc19f4 View commit details
    Browse the repository at this point in the history

  7. release PHP 7.2 downgraded

    @actions-user
    actions-user committed Jan 31, 2025
    Configuration menu
    Copy the full SHA
    2bf0e46 View commit details
    Browse the repository at this point in the history
Loading