Escape query used in opportunity search. This addresses the reported issue "[Bug] Searching "C++" returns 500 error on /jobs".

lokst · lokst · commit e442a3c92d83 · 2015-04-08T23:10:37.000+08:00
Added the relevant tests to opportunity controller spec.
diff --git a/app/controllers/opportunities_controller.rb b/app/controllers/opportunities_controller.rb
@@ -166,14 +166,16 @@ def geocode_location(location)
   def get_jobs_for(chosen_location, tag, page, query = nil, remote_allowed = false)
     scope = Opportunity
 
+    escaped_query = query.nil? ? query : Regexp.escape(query)
+
     if remote_allowed
       scope = scope.where(remote: true)
     else
       scope = scope.by_city(chosen_location) if chosen_location && chosen_location.length > 0
     end
 
     scope = scope.by_tag(tag) unless tag.nil?
-    scope = scope.by_query(query) if query
+    scope = scope.by_query(escaped_query) if escaped_query
     # TODO: Verify that there are no unmigrated teams
     scope = scope.where('team_id is not null')
     scope.offset((page-1) * 20)
diff --git a/spec/controllers/opportunity_controlller_spec.rb b/spec/controllers/opportunity_controlller_spec.rb
@@ -46,6 +46,17 @@
           expect(assigns(:jobs)).to_not be_include(@opportunity2)
         end
       end
+
+      context "by query with keywords containing regexp special characters" do
+        it "should NOT fail when querying with keywords containing '+'" do
+          get :index, location: nil, q: 'C++'
+          expect(assigns(:jobs))
+        end
+        it "should NOT fail when querying with keywords containing '.^$*+?()[{\|'" do
+          get :index, location: nil, q: 'java .^$*+?()[{\|'
+          expect(assigns(:jobs))
+        end
+      end
     end
   end
 end
