Skip to content

chore: ensure correct scopes are in place #22397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2020
Merged

chore: ensure correct scopes are in place #22397

merged 1 commit into from
Feb 28, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Feb 26, 2020 •
edited
Loading

Description of Change

In ongoing efforts to match ELECTRON_RUN_AS_NODE as closely as possible to Node.js main instance execution, we should ensure that that scopes we have in place are correct.

cc @MarshallOfSound @zcbenz @nornagon

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Feb 26, 2020
codebytere
codebytere commented Feb 26, 2020
View reviewed changes
shell/app/node_main.cc
@@ -138,10 +138,16 @@ int NodeMain(int argc, char* argv[]) {
// Initialize gin::IsolateHolder.
JavascriptEnvironment gin_env(loop);

v8::Isolate* isolate = gin_env.isolate();
Copy link
Member Author

@codebytere codebytere Feb 26, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the isolate we were pulling out of the Node.js env is the same as the one in gin_env (the one in gin_env is used when creating the Node.js env), so this simply makes that clearer to the reader.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Feb 28, 2020
@codebytere codebytere merged commit ed33a72 into master Feb 28, 2020
@release-clerk
Copy link

release-clerk bot commented Feb 28, 2020

No Release Notes

@codebytere codebytere deleted the add-some-scopes branch February 28, 2020 23:08
@trop
Copy link
Contributor

trop bot commented Feb 28, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/8-x-y label Feb 28, 2020
@trop
Copy link
Contributor

trop bot commented Feb 28, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@codebytere codebytere mentioned this pull request Mar 2, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Mar 2, 2020

@codebytere has manually backported this PR to "9-x-y", please check out #22479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @zcbenz @MarshallOfSound