Skip to content

Commit 0041e60

Browse files
Rex Zhualexdeucher
authored andcommitted
drm/amd/powerplay: delete SMUM_WAIT_INDIRECT_FIELD
repeated defining in hwmgr.h use PHM_WAIT_INDIRECT_FIELD instand. Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 515113f commit 0041e60

File tree

3 files changed

+2
-13
lines changed

3 files changed

+2
-13
lines changed

drivers/gpu/drm/amd/powerplay/inc/smumgr.h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -151,17 +151,6 @@ extern bool smum_is_hw_avfs_present(struct pp_hwmgr *hwmgr);
151151

152152
#define SMUM_FIELD_MASK(reg, field) reg##__##field##_MASK
153153

154-
#define SMUM_WAIT_INDIRECT_REGISTER_GIVEN_INDEX(hwmgr, \
155-
port, index, value, mask) \
156-
smum_wait_on_indirect_register(hwmgr, \
157-
mm##port##_INDEX, index, value, mask)
158-
159-
#define SMUM_WAIT_INDIRECT_REGISTER(hwmgr, port, reg, value, mask) \
160-
SMUM_WAIT_INDIRECT_REGISTER_GIVEN_INDEX(hwmgr, port, ix##reg, value, mask)
161-
162-
#define SMUM_WAIT_INDIRECT_FIELD(hwmgr, port, reg, field, fieldval) \
163-
SMUM_WAIT_INDIRECT_REGISTER(hwmgr, port, reg, (fieldval) << SMUM_FIELD_SHIFT(reg, field), \
164-
SMUM_FIELD_MASK(reg, field) )
165154

166155
#define SMUM_GET_FIELD(value, reg, field) \
167156
(((value) & SMUM_FIELD_MASK(reg, field)) \

drivers/gpu/drm/amd/powerplay/smumgr/ci_smc.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1938,7 +1938,7 @@ static int ci_start_smc(struct pp_hwmgr *hwmgr)
19381938

19391939
PHM_WRITE_INDIRECT_FIELD(hwmgr->device, CGS_IND_REG__SMC, SMC_SYSCON_RESET_CNTL, rst_reg, 0);
19401940

1941-
SMUM_WAIT_INDIRECT_FIELD(hwmgr, SMC_IND, FIRMWARE_FLAGS,
1941+
PHM_WAIT_INDIRECT_FIELD(hwmgr, SMC_IND, FIRMWARE_FLAGS,
19421942
INTERRUPTS_ENABLED, 1);
19431943

19441944
return 0;

drivers/gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ static int iceland_smu_start_smc(struct pp_hwmgr *hwmgr)
8080
/* de-assert reset */
8181
iceland_start_smc(hwmgr);
8282

83-
SMUM_WAIT_INDIRECT_FIELD(hwmgr, SMC_IND, FIRMWARE_FLAGS,
83+
PHM_WAIT_INDIRECT_FIELD(hwmgr, SMC_IND, FIRMWARE_FLAGS,
8484
INTERRUPTS_ENABLED, 1);
8585

8686
return 0;

0 commit comments

Comments
 (0)