drm/mm: Don't WARN if drm_mm_reserve_node

danvet · jnikula · commit 004f388559a8 · 2014-04-10T10:54:47.000+03:00
Jesse's BIOS fb reconstruction code actually relies on the -ENOSPC
return value to detect overlapping framebuffers (which the bios uses
always when lighting up more than one screen). All this fanciness
happens in intel_alloc_plane_obj in intel_display.c.

Since no one else uses this we can safely remove the WARN without
repercussions.

Reported-by: Ben Widawsky &lt;benjamin.widawsky@intel.com&gt;
Tested-by: Ben Widawsky &lt;ben@bwidawsk.net&gt;
Cc: Jesse Barnes &lt;jbarnes@virtuousgeek.org&gt;
Cc: Dave Airlie &lt;airlied@redhat.com&gt;
Signed-off-by: Daniel Vetter &lt;daniel.vetter@ffwll.ch&gt;
Acked-by: Dave Airlie &lt;airlied@redhat.com&gt;
Signed-off-by: Jani Nikula &lt;jani.nikula@intel.com&gt;
diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
@@ -207,8 +207,6 @@ int drm_mm_reserve_node(struct drm_mm *mm, struct drm_mm_node *node)
 		return 0;
 	}
 
-	WARN(1, "no hole found for node 0x%lx + 0x%lx\n",
-	     node->start, node->size);
 	return -ENOSPC;
 }
 EXPORT_SYMBOL(drm_mm_reserve_node);

Original file line number	Diff line number	Diff line change
`@@ -207,8 +207,6 @@ int drm_mm_reserve_node(struct drm_mm mm, struct drm_mm_node node)`
`207`	`207`	`return 0;`
`208`	`208`	`}`
`209`	`209`
`210`		`- WARN(1, "no hole found for node 0x%lx + 0x%lx\n",`
`211`		`- node->start, node->size);`
`212`	`210`	`return -ENOSPC;`
`213`	`211`	`}`
`214`	`212`	`EXPORT_SYMBOL(drm_mm_reserve_node);`