ethernet: mvneta: Use PHY status standard message

ezequielgarcia · davem330 · commit 0089b745df2e · 2014-10-31T16:11:23.000-04:00
Use phy_print_status() to report a change in the PHY status.
The current message is not verbose enough, so this commit improves
it by using the generic status message.

After this change, the kernel reports PHY status down and up events as:

mvneta f1070000.ethernet eth0: Link is Down
mvneta f1070000.ethernet eth0: Link is Up - 1Gbps/Full - flow control rx/tx

Signed-off-by: Ezequiel Garcia &lt;ezequiel.garcia@free-electrons.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
@@ -2558,11 +2558,10 @@ static void mvneta_adjust_link(struct net_device *ndev)
 				MVNETA_GMAC_FORCE_LINK_DOWN);
 			mvreg_write(pp, MVNETA_GMAC_AUTONEG_CONFIG, val);
 			mvneta_port_up(pp);
-			netdev_info(pp->dev, "link up\n");
 		} else {
 			mvneta_port_down(pp);
-			netdev_info(pp->dev, "link down\n");
 		}
+		phy_print_status(phydev);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2558,11 +2558,10 @@ static void mvneta_adjust_link(struct net_device *ndev)`
`2558`	`2558`	`MVNETA_GMAC_FORCE_LINK_DOWN);`
`2559`	`2559`	`mvreg_write(pp, MVNETA_GMAC_AUTONEG_CONFIG, val);`
`2560`	`2560`	`mvneta_port_up(pp);`
`2561`		`- netdev_info(pp->dev, "link up\n");`
`2562`	`2561`	`} else {`
`2563`	`2562`	`mvneta_port_down(pp);`
`2564`		`- netdev_info(pp->dev, "link down\n");`
`2565`	`2563`	`}`
	`2564`	`+ phy_print_status(phydev);`
`2566`	`2565`	`}`
`2567`	`2566`	`}`
`2568`	`2567`