tipc: avoid double lock 'spin_lock:&seq->lock'

ying-xue · davem330 · commit 023160bc8f10 · 2014-12-09T18:27:03.000-05:00
The commit fb9962f ("tipc: ensure all name sequences are properly protected with its lock") involves below errors: net/tipc/name_table.c:980 tipc_purge_publications() error: double lock 'spin_lock:&seq->lock' Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Ying Xue <ying.xue@windriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/net/tipc/name_table.c b/net/tipc/name_table.c
@@ -979,7 +979,7 @@ static void tipc_purge_publications(struct name_seq *seq)
 	}
 	hlist_del_init_rcu(&seq->ns_list);
 	kfree(seq->sseqs);
-	spin_lock_bh(&seq->lock);
+	spin_unlock_bh(&seq->lock);
 
 	kfree_rcu(seq, rcu);
 }

Original file line number	Diff line number	Diff line change
`@@ -979,7 +979,7 @@ static void tipc_purge_publications(struct name_seq *seq)`
`979`	`979`	`}`
`980`	`980`	`hlist_del_init_rcu(&seq->ns_list);`
`981`	`981`	`kfree(seq->sseqs);`
`982`		`- spin_lock_bh(&seq->lock);`
	`982`	`+ spin_unlock_bh(&seq->lock);`
`983`	`983`
`984`	`984`	`kfree_rcu(seq, rcu);`
`985`	`985`	`}`