USB: FHCI: use list_move_tail instead of list_del/list_add_tail

Wei Yongjun · gregkh · commit 027c5215a9b5 · 2012-09-05T16:55:18.000-07:00
Using list_move_tail() instead of list_del() + list_add_tail(). spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/host/fhci-sched.c b/drivers/usb/host/fhci-sched.c
@@ -261,8 +261,7 @@ static void move_head_to_tail(struct list_head *list)
 	struct list_head *node = list->next;
 
 	if (!list_empty(list)) {
-		list_del(node);
-		list_add_tail(node, list);
+		list_move_tail(node, list);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -261,8 +261,7 @@ static void move_head_to_tail(struct list_head *list)`
`261`	`261`	`struct list_head *node = list->next;`
`262`	`262`
`263`	`263`	`if (!list_empty(list)) {`
`264`		`- list_del(node);`
`265`		`- list_add_tail(node, list);`
	`264`	`+ list_move_tail(node, list);`
`266`	`265`	`}`
`267`	`266`	`}`
`268`	`267`