Skip to content

Commit 048b899

Browse files
stephen hemmingerdavem330
authored andcommitted
etherdevice: fix comments
Fix some minor problems in comments of etherdevice.h * Warning is out dated, file hasn't moved or disappeared in many years and is unlikely to do so soon. * Capitalize Ethernet consistently since it is a proper name * Fix descriptive comment of padding * Spelling and grammar fix for alignment comment Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 3b12bb6 commit 048b899

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

include/linux/etherdevice.h

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
* as published by the Free Software Foundation; either version
1919
* 2 of the License, or (at your option) any later version.
2020
*
21-
* WARNING: This move may well be temporary. This file will get merged with others RSN.
22-
*
2321
*/
2422
#ifndef _LINUX_ETHERDEVICE_H
2523
#define _LINUX_ETHERDEVICE_H
@@ -159,7 +157,7 @@ static inline void eth_hw_addr_random(struct net_device *dev)
159157
* @addr1: Pointer to a six-byte array containing the Ethernet address
160158
* @addr2: Pointer other six-byte array containing the Ethernet address
161159
*
162-
* Compare two ethernet addresses, returns 0 if equal, non-zero otherwise.
160+
* Compare two Ethernet addresses, returns 0 if equal, non-zero otherwise.
163161
* Unlike memcmp(), it doesn't return a value suitable for sorting.
164162
*/
165163
static inline unsigned compare_ether_addr(const u8 *addr1, const u8 *addr2)
@@ -176,7 +174,7 @@ static inline unsigned compare_ether_addr(const u8 *addr1, const u8 *addr2)
176174
* @addr1: Pointer to a six-byte array containing the Ethernet address
177175
* @addr2: Pointer other six-byte array containing the Ethernet address
178176
*
179-
* Compare two ethernet addresses, returns true if equal
177+
* Compare two Ethernet addresses, returns true if equal
180178
*/
181179
static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2)
182180
{
@@ -197,13 +195,13 @@ static inline unsigned long zap_last_2bytes(unsigned long value)
197195
* @addr1: Pointer to an array of 8 bytes
198196
* @addr2: Pointer to an other array of 8 bytes
199197
*
200-
* Compare two ethernet addresses, returns true if equal, false otherwise.
198+
* Compare two Ethernet addresses, returns true if equal, false otherwise.
201199
*
202200
* The function doesn't need any conditional branches and possibly uses
203201
* word memory accesses on CPU allowing cheap unaligned memory reads.
204-
* arrays = { byte1, byte2, byte3, byte4, byte6, byte7, pad1, pad2}
202+
* arrays = { byte1, byte2, byte3, byte4, byte5, byte6, pad1, pad2 }
205203
*
206-
* Please note that alignment of addr1 & addr2 is only guaranted to be 16 bits.
204+
* Please note that alignment of addr1 & addr2 are only guaranteed to be 16 bits.
207205
*/
208206

209207
static inline bool ether_addr_equal_64bits(const u8 addr1[6+2],
@@ -257,7 +255,7 @@ static inline bool is_etherdev_addr(const struct net_device *dev,
257255
* @a: Pointer to Ethernet header
258256
* @b: Pointer to Ethernet header
259257
*
260-
* Compare two ethernet headers, returns 0 if equal.
258+
* Compare two Ethernet headers, returns 0 if equal.
261259
* This assumes that the network header (i.e., IP header) is 4-byte
262260
* aligned OR the platform can handle unaligned access. This is the
263261
* case for all packets coming into netif_receive_skb or similar

0 commit comments

Comments
 (0)