Skip to content

Commit 05a5648

Browse files
rfredzimdavem330
authored andcommitted
net: cdc_ncm: update datagram size after changing mtu
Current implementation updates the mtu size and notify cdc_ncm device using USB_CDC_SET_MAX_DATAGRAM_SIZE request about datagram size change instead of changing rx_urb_size. Whenever mtu is being changed, datagram size should also be updated. Also updating maxmtu formula so it takes max_datagram_size with use of cdc_ncm_max_dgram_size() and not ctx. Signed-off-by: Robert Dobrowolski <robert.dobrowolski@linux.intel.com> Signed-off-by: Rafal Redzimski <rafal.f.redzimski@intel.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent addf8fc commit 05a5648

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/net/usb/cdc_ncm.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -740,12 +740,14 @@ static void cdc_ncm_free(struct cdc_ncm_ctx *ctx)
740740
int cdc_ncm_change_mtu(struct net_device *net, int new_mtu)
741741
{
742742
struct usbnet *dev = netdev_priv(net);
743-
struct cdc_ncm_ctx *ctx = (struct cdc_ncm_ctx *)dev->data[0];
744-
int maxmtu = ctx->max_datagram_size - cdc_ncm_eth_hlen(dev);
743+
int maxmtu = cdc_ncm_max_dgram_size(dev) - cdc_ncm_eth_hlen(dev);
745744

746745
if (new_mtu <= 0 || new_mtu > maxmtu)
747746
return -EINVAL;
747+
748748
net->mtu = new_mtu;
749+
cdc_ncm_set_dgram_size(dev, new_mtu + cdc_ncm_eth_hlen(dev));
750+
749751
return 0;
750752
}
751753
EXPORT_SYMBOL_GPL(cdc_ncm_change_mtu);

0 commit comments

Comments
 (0)