usb: gadget: udc: net2272: Fix bitwise and boolean operations

GustavoARSilva · Felipe Balbi · commit 07c69f1148da · 2019-01-28T15:27:21.000+02:00
(!x & y) strikes again. Fix bitwise and boolean operations by enclosing the expression: intcsr & (1 << NET2272_PCI_IRQ) in parentheses, before applying the boolean operator '!'. Notice that this code has been there since 2011. So, it would be helpful if someone can double-check this. This issue was detected with the help of Coccinelle. Fixes: ceb8036 ("USB: net2272: driver for PLX NET2272 USB device controller") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c
@@ -2083,7 +2083,7 @@ static irqreturn_t net2272_irq(int irq, void *_dev)
 #if defined(PLX_PCI_RDK2)
 	/* see if PCI int for us by checking irqstat */
 	intcsr = readl(dev->rdk2.fpga_base_addr + RDK2_IRQSTAT);
-	if (!intcsr & (1 << NET2272_PCI_IRQ)) {
+	if (!(intcsr & (1 << NET2272_PCI_IRQ))) {
 		spin_unlock(&dev->lock);
 		return IRQ_NONE;
 	}

Original file line number	Diff line number	Diff line change
`@@ -2083,7 +2083,7 @@ static irqreturn_t net2272_irq(int irq, void *_dev)`
`2083`	`2083`	`#if defined(PLX_PCI_RDK2)`
`2084`	`2084`	`/* see if PCI int for us by checking irqstat */`
`2085`	`2085`	`intcsr = readl(dev->rdk2.fpga_base_addr + RDK2_IRQSTAT);`
`2086`		`- if (!intcsr & (1 << NET2272_PCI_IRQ)) {`
	`2086`	`+ if (!(intcsr & (1 << NET2272_PCI_IRQ))) {`
`2087`	`2087`	`spin_unlock(&dev->lock);`
`2088`	`2088`	`return IRQ_NONE;`
`2089`	`2089`	`}`