staging: rts5208: remove unnecessary else

RoxanaGabriela · gregkh · commit 07f113b5d5a8 · 2014-10-02T10:07:04.000-07:00
This fixes the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return

Signed-off-by: Roxana Blaj &lt;roxanagabriela10@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/staging/rts5208/rtsx_scsi.c b/drivers/staging/rts5208/rtsx_scsi.c
@@ -586,10 +586,9 @@ static int start_stop_unit(struct scsi_cmnd *srb, struct rtsx_chip *chip)
 	case LOAD_MEDIUM:
 		if (check_card_ready(chip, lun)) {
 			return TRANSPORT_GOOD;
-		} else {
-			set_sense_type(chip, lun, SENSE_TYPE_MEDIA_NOT_PRESENT);
-			TRACE_RET(chip, TRANSPORT_FAILED);
 		}
+		set_sense_type(chip, lun, SENSE_TYPE_MEDIA_NOT_PRESENT);
+		TRACE_RET(chip, TRANSPORT_FAILED);
 
 		break;
 	}

Original file line number	Diff line number	Diff line change
`@@ -586,10 +586,9 @@ static int start_stop_unit(struct scsi_cmnd srb, struct rtsx_chip chip)`
`586`	`586`	`case LOAD_MEDIUM:`
`587`	`587`	`if (check_card_ready(chip, lun)) {`
`588`	`588`	`return TRANSPORT_GOOD;`
`589`		`- } else {`
`590`		`- set_sense_type(chip, lun, SENSE_TYPE_MEDIA_NOT_PRESENT);`
`591`		`- TRACE_RET(chip, TRANSPORT_FAILED);`
`592`	`589`	`}`
	`590`	`+ set_sense_type(chip, lun, SENSE_TYPE_MEDIA_NOT_PRESENT);`
	`591`	`+ TRACE_RET(chip, TRANSPORT_FAILED);`
`593`	`592`
`594`	`593`	`break;`
`595`	`594`	`}`