drm/exynos: Restrict plane loops to only operate on overlay planes (v2)

mattrope · robclark · commit 0886327aae9a · 2014-04-01T20:11:18.000-04:00
Ensure that existing driver loops over all planes do not change behavior
when we begin adding new types of planes (primary and cursor) to the DRM
plane list in future patches.

v2: Switch to using drm_for_each_legacy_plane()

Cc: Inki Dae &lt;inki.dae@samsung.com&gt;
Signed-off-by: Matt Roper &lt;matthew.d.roper@intel.com&gt;
diff --git a/drivers/gpu/drm/exynos/exynos_drm_crtc.c b/drivers/gpu/drm/exynos/exynos_drm_crtc.c
@@ -190,7 +190,7 @@ static void exynos_drm_crtc_disable(struct drm_crtc *crtc)
 
 	exynos_drm_crtc_dpms(crtc, DRM_MODE_DPMS_OFF);
 
-	list_for_each_entry(plane, &crtc->dev->mode_config.plane_list, head) {
+	drm_for_each_legacy_plane(plane, &crtc->dev->mode_config.plane_list) {
 		if (plane->crtc != crtc)
 			continue;
 
diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
@@ -101,7 +101,7 @@ static void exynos_drm_encoder_disable(struct drm_encoder *encoder)
 	exynos_drm_encoder_dpms(encoder, DRM_MODE_DPMS_OFF);
 
 	/* all planes connected to this encoder should be also disabled. */
-	list_for_each_entry(plane, &dev->mode_config.plane_list, head) {
+	drm_for_each_legacy_plane(plane, &dev->mode_config.plane_list) {
 		if (plane->crtc == encoder->crtc)
 			plane->funcs->disable_plane(plane);
 	}

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ static void exynos_drm_encoder_disable(struct drm_encoder *encoder)`
`101`	`101`	`exynos_drm_encoder_dpms(encoder, DRM_MODE_DPMS_OFF);`
`102`	`102`
`103`	`103`	`/* all planes connected to this encoder should be also disabled. */`
`104`		`- list_for_each_entry(plane, &dev->mode_config.plane_list, head) {`
	`104`	`+ drm_for_each_legacy_plane(plane, &dev->mode_config.plane_list) {`
`105`	`105`	`if (plane->crtc == encoder->crtc)`
`106`	`106`	`plane->funcs->disable_plane(plane);`
`107`	`107`	`}`