usb: gadget: net2272: Fix net2272_dequeue()

GuidoKiener · Felipe Balbi · commit 091dacc3cc10 · 2019-03-20T08:50:42.000+02:00
Restore the status of ep-&gt;stopped in function net2272_dequeue().

When the given request is not found in the endpoint queue
the function returns -EINVAL without restoring the state of
ep-&gt;stopped. Thus the endpoint keeps blocked and does not transfer
any data anymore.

This fix is only compile-tested, since we do not have a
corresponding hardware. An analogous fix was tested in the sibling
driver. See "usb: gadget: net2280: Fix net2280_dequeue()"

Acked-by: Alan Stern &lt;stern@rowland.harvard.edu&gt;
Signed-off-by: Guido Kiener &lt;guido.kiener@rohde-schwarz.com&gt;
Signed-off-by: Felipe Balbi &lt;felipe.balbi@linux.intel.com&gt;
diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c
@@ -945,6 +945,7 @@ net2272_dequeue(struct usb_ep *_ep, struct usb_request *_req)
 			break;
 	}
 	if (&req->req != _req) {
+		ep->stopped = stopped;
 		spin_unlock_irqrestore(&ep->dev->lock, flags);
 		return -EINVAL;
 	}

Original file line number	Diff line number	Diff line change
`@@ -945,6 +945,7 @@ net2272_dequeue(struct usb_ep _ep, struct usb_request _req)`
`945`	`945`	`break;`
`946`	`946`	`}`
`947`	`947`	`if (&req->req != _req) {`
	`948`	`+ ep->stopped = stopped;`
`948`	`949`	`spin_unlock_irqrestore(&ep->dev->lock, flags);`
`949`	`950`	`return -EINVAL;`
`950`	`951`	`}`