rds: tcp: use sock_create_lite() to create the accept socket

sowminiv · davem330 · commit 0933a578cd55 · 2017-07-08T11:16:16.000+01:00
There are two problems with calling sock_create_kern() from
rds_tcp_accept_one()
1. it sets up a new_sock-&gt;sk that is wasteful, because this -&gt;sk
   is going to get replaced by inet_accept() in the subsequent -&gt;accept()
2. The new_sock-&gt;sk is a leaked reference in sock_graft() which
   expects to find a null parent-&gt;sk

Avoid these problems by calling sock_create_lite().

Signed-off-by: Sowmini Varadhan &lt;sowmini.varadhan@oracle.com&gt;
Acked-by: Santosh Shilimkar &lt;santosh.shilimkar@oracle.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/rds/tcp_listen.c b/net/rds/tcp_listen.c
@@ -136,7 +136,7 @@ int rds_tcp_accept_one(struct socket *sock)
 	if (!sock) /* module unload or netns delete in progress */
 		return -ENETUNREACH;
 
-	ret = sock_create_kern(sock_net(sock->sk), sock->sk->sk_family,
+	ret = sock_create_lite(sock->sk->sk_family,
 			       sock->sk->sk_type, sock->sk->sk_protocol,
 			       &new_sock);
 	if (ret)
