tpm/st33zp24: Remove useless tpm_gen_interrupt

jgunthorpe · Jarkko Sakkinen · commit 09dd7703753f · 2016-09-15T16:04:21.000+03:00
This function should only be called as part of an IRQ probing protocol
and st33 does not have any code to detect that the IRQ it tries to
generate was not generated and disable the IRQ.

Since st33 is primarily a DT binding driver it should not be doing
IRQ probing anyhow, so let us just delete this useless call.

Signed-off-by: Jason Gunthorpe &lt;jgunthorpe@obsidianresearch.com&gt;
Reviewed-by: Jarkko Sakkinen &lt;jarkko.sakkinen@linux.intel.com&gt;
Signed-off-by: Jarkko Sakkinen &lt;jarkko.sakkinen@linux.intel.com&gt;
diff --git a/drivers/char/tpm/st33zp24/st33zp24.c b/drivers/char/tpm/st33zp24/st33zp24.c
@@ -589,8 +589,6 @@ int st33zp24_probe(void *phy_id, const struct st33zp24_phy_ops *ops,
 		chip->flags |= TPM_CHIP_FLAG_IRQ;
 
 		disable_irq_nosync(tpm_dev->irq);
-
-		tpm_gen_interrupt(chip);
 	}
 
 	return tpm_chip_register(chip);

Original file line number	Diff line number	Diff line change
`@@ -589,8 +589,6 @@ int st33zp24_probe(void phy_id, const struct st33zp24_phy_ops ops,`
`589`	`589`	`chip->flags \|= TPM_CHIP_FLAG_IRQ;`
`590`	`590`
`591`	`591`	`disable_irq_nosync(tpm_dev->irq);`
`592`		`-`
`593`		`- tpm_gen_interrupt(chip);`
`594`	`592`	`}`
`595`	`593`
`596`	`594`	`return tpm_chip_register(chip);`