ACPI / utils: Fix memory leak in acpi_evaluate_reference() error path

fenghusthu · rafaeljw · commit 09e15086936e · 2017-11-14T12:54:55.000+01:00
When package.count is larger than ACPI_MAX_HANDLES, buffer.pointer is
not freed before the function returns AE_NO_MEMORY. Fix this possible
memory leak by kfree'ing it.

Signed-off-by: Xiongfeng Wang &lt;wangxiongfeng2@huawei.com&gt;
Signed-off-by: Rafael J. Wysocki &lt;rafael.j.wysocki@intel.com&gt;
diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
@@ -355,6 +355,7 @@ acpi_evaluate_reference(acpi_handle handle,
 	}
 
 	if (package->package.count > ACPI_MAX_HANDLES) {
+		kfree(package);
 		return AE_NO_MEMORY;
 	}
 	list->count = package->package.count;

Original file line number	Diff line number	Diff line change
`@@ -355,6 +355,7 @@ acpi_evaluate_reference(acpi_handle handle,`
`355`	`355`	`}`
`356`	`356`
`357`	`357`	`if (package->package.count > ACPI_MAX_HANDLES) {`
	`358`	`+ kfree(package);`
`358`	`359`	`return AE_NO_MEMORY;`
`359`	`360`	`}`
`360`	`361`	`list->count = package->package.count;`