selftests: pmtu: properly redirect stderr to /dev/null

qsn · davem330 · commit 0a286afee5a1 · 2018-09-18T19:53:58.000-07:00
The cleanup function uses "$CMD 2 > /dev/null", which doesn't actually send stderr to /dev/null, so when the netns doesn't exist, the error message is shown. Use "2> /dev/null" instead, so that those messages disappear, as was intended. Fixes: d1f1b9c ("selftests: net: Introduce first PMTU test") Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> Acked-by: Stefano Brivio <sbrivio@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh
@@ -178,8 +178,8 @@ setup() {
 
 cleanup() {
 	[ ${cleanup_done} -eq 1 ] && return
-	ip netns del ${NS_A} 2 > /dev/null
-	ip netns del ${NS_B} 2 > /dev/null
+	ip netns del ${NS_A} 2> /dev/null
+	ip netns del ${NS_B} 2> /dev/null
 	cleanup_done=1
 }
 

Original file line number	Diff line number	Diff line change
`@@ -178,8 +178,8 @@ setup() {`
`178`	`178`
`179`	`179`	`cleanup() {`
`180`	`180`	`[ ${cleanup_done} -eq 1 ] && return`
`181`		`- ip netns del ${NS_A} 2 > /dev/null`
`182`		`- ip netns del ${NS_B} 2 > /dev/null`
	`181`	`+ ip netns del ${NS_A} 2> /dev/null`
	`182`	`+ ip netns del ${NS_B} 2> /dev/null`
`183`	`183`	`cleanup_done=1`
`184`	`184`	`}`
`185`	`185`