nfsd: fix fall-through annotations

GustavoARSilva · J. Bruce Fields · commit 0ac203cb1f03 · 2018-10-29T16:58:04.000-04:00
Replace "fallthru" with a proper "fall through" annotation.

Also, add an annotation were it is expected to fall through.

These fixes are part of the ongoing efforts to enabling
-Wimplicit-fallthrough

Signed-off-by: Gustavo A. R. Silva &lt;gustavo@embeddedor.com&gt;
Signed-off-by: J. Bruce Fields &lt;bfields@redhat.com&gt;
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
@@ -1406,6 +1406,7 @@ do_nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp,
 					*created = 1;
 				break;
 			}
+			/* fall through */
 		case NFS4_CREATE_EXCLUSIVE4_1:
 			if (   d_inode(dchild)->i_mtime.tv_sec == v_mtime
 			    && d_inode(dchild)->i_atime.tv_sec == v_atime
@@ -1414,7 +1415,7 @@ do_nfsd_create(struct svc_rqst *rqstp, struct svc_fh *fhp,
 					*created = 1;
 				goto set_attr;
 			}
-			 /* fallthru */
+			/* fall through */
 		case NFS3_CREATE_GUARDED:
 			err = nfserr_exist;
 		}

Original file line number	Diff line number	Diff line change
`@@ -1406,6 +1406,7 @@ do_nfsd_create(struct svc_rqst rqstp, struct svc_fh fhp,`
`1406`	`1406`	`*created = 1;`
`1407`	`1407`	`break;`
`1408`	`1408`	`}`
	`1409`	`+ /* fall through */`
`1409`	`1410`	`case NFS4_CREATE_EXCLUSIVE4_1:`
`1410`	`1411`	`if ( d_inode(dchild)->i_mtime.tv_sec == v_mtime`
`1411`	`1412`	`&& d_inode(dchild)->i_atime.tv_sec == v_atime`
`@@ -1414,7 +1415,7 @@ do_nfsd_create(struct svc_rqst rqstp, struct svc_fh fhp,`
`1414`	`1415`	`*created = 1;`
`1415`	`1416`	`goto set_attr;`
`1416`	`1417`	`}`
`1417`		`- /* fallthru */`
	`1418`	`+ /* fall through */`
`1418`	`1419`	`case NFS3_CREATE_GUARDED:`
`1419`	`1420`	`err = nfserr_exist;`
`1420`	`1421`	`}`