reset: fix optional reset_control_get stubs to return NULL

pH5 · pH5 · commit 0ca10b60ceeb · 2017-03-21T18:19:43.000+01:00
When RESET_CONTROLLER is not enabled, the optional reset_control_get stubs should now also return NULL. Since it is now valid for reset_control_assert/deassert/reset/status/put to be called unconditionally, with NULL as an argument for optional resets, the stubs are not allowed to warn anymore. Fixes: bb47523 ("reset: make optional functions really optional") Reported-by: Andrzej Hajda <a.hajda@samsung.com> Tested-by: Andrzej Hajda <a.hajda@samsung.com> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> Cc: Ramiro Oliveira <Ramiro.Oliveira@synopsys.com> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
diff --git a/include/linux/reset.h b/include/linux/reset.h
@@ -31,31 +31,26 @@ static inline int device_reset_optional(struct device *dev)
 
 static inline int reset_control_reset(struct reset_control *rstc)
 {
-	WARN_ON(1);
 	return 0;
 }
 
 static inline int reset_control_assert(struct reset_control *rstc)
 {
-	WARN_ON(1);
 	return 0;
 }
 
 static inline int reset_control_deassert(struct reset_control *rstc)
 {
-	WARN_ON(1);
 	return 0;
 }
 
 static inline int reset_control_status(struct reset_control *rstc)
 {
-	WARN_ON(1);
 	return 0;
 }
 
 static inline void reset_control_put(struct reset_control *rstc)
 {
-	WARN_ON(1);
 }
 
 static inline int __must_check device_reset(struct device *dev)
@@ -74,14 +69,14 @@ static inline struct reset_control *__of_reset_control_get(
 					const char *id, int index, bool shared,
 					bool optional)
 {
-	return ERR_PTR(-ENOTSUPP);
+	return optional ? NULL : ERR_PTR(-ENOTSUPP);
 }
 
 static inline struct reset_control *__devm_reset_control_get(
 					struct device *dev, const char *id,
 					int index, bool shared, bool optional)
 {
-	return ERR_PTR(-ENOTSUPP);
+	return optional ? NULL : ERR_PTR(-ENOTSUPP);
 }
 
 #endif /* CONFIG_RESET_CONTROLLER */

Original file line number	Diff line number	Diff line change
`@@ -31,31 +31,26 @@ static inline int device_reset_optional(struct device *dev)`
`31`	`31`
`32`	`32`	`static inline int reset_control_reset(struct reset_control *rstc)`
`33`	`33`	`{`
`34`		`- WARN_ON(1);`
`35`	`34`	`return 0;`
`36`	`35`	`}`
`37`	`36`
`38`	`37`	`static inline int reset_control_assert(struct reset_control *rstc)`
`39`	`38`	`{`
`40`		`- WARN_ON(1);`
`41`	`39`	`return 0;`
`42`	`40`	`}`
`43`	`41`
`44`	`42`	`static inline int reset_control_deassert(struct reset_control *rstc)`
`45`	`43`	`{`
`46`		`- WARN_ON(1);`
`47`	`44`	`return 0;`
`48`	`45`	`}`
`49`	`46`
`50`	`47`	`static inline int reset_control_status(struct reset_control *rstc)`
`51`	`48`	`{`
`52`		`- WARN_ON(1);`
`53`	`49`	`return 0;`
`54`	`50`	`}`
`55`	`51`
`56`	`52`	`static inline void reset_control_put(struct reset_control *rstc)`
`57`	`53`	`{`
`58`		`- WARN_ON(1);`
`59`	`54`	`}`
`60`	`55`
`61`	`56`	`static inline int __must_check device_reset(struct device *dev)`
`@@ -74,14 +69,14 @@ static inline struct reset_control *__of_reset_control_get(`
`74`	`69`	`const char *id, int index, bool shared,`
`75`	`70`	`bool optional)`
`76`	`71`	`{`
`77`		`- return ERR_PTR(-ENOTSUPP);`
	`72`	`+ return optional ? NULL : ERR_PTR(-ENOTSUPP);`
`78`	`73`	`}`
`79`	`74`
`80`	`75`	`static inline struct reset_control *__devm_reset_control_get(`
`81`	`76`	`struct device dev, const char id,`
`82`	`77`	`int index, bool shared, bool optional)`
`83`	`78`	`{`
`84`		`- return ERR_PTR(-ENOTSUPP);`
	`79`	`+ return optional ? NULL : ERR_PTR(-ENOTSUPP);`
`85`	`80`	`}`
`86`	`81`
`87`	`82`	`#endif /* CONFIG_RESET_CONTROLLER */`