Skip to content

Commit 0d1632b

Browse files
Jiri Pirkodavem330
authored andcommitted
dummy: use IFF_LIVE_ADDR_CHANGE priv_flag
Signed-off-by: Jiri Pirko <jpirko@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 5a1d1c8 commit 0d1632b

File tree

1 file changed

+2
-13
lines changed

1 file changed

+2
-13
lines changed

drivers/net/dummy.c

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,6 @@
4040

4141
static int numdummies = 1;
4242

43-
static int dummy_set_address(struct net_device *dev, void *p)
44-
{
45-
struct sockaddr *sa = p;
46-
47-
if (!is_valid_ether_addr(sa->sa_data))
48-
return -EADDRNOTAVAIL;
49-
50-
dev->addr_assign_type &= ~NET_ADDR_RANDOM;
51-
memcpy(dev->dev_addr, sa->sa_data, ETH_ALEN);
52-
return 0;
53-
}
54-
5543
/* fake multicast ability */
5644
static void set_multicast_list(struct net_device *dev)
5745
{
@@ -118,7 +106,7 @@ static const struct net_device_ops dummy_netdev_ops = {
118106
.ndo_start_xmit = dummy_xmit,
119107
.ndo_validate_addr = eth_validate_addr,
120108
.ndo_set_rx_mode = set_multicast_list,
121-
.ndo_set_mac_address = dummy_set_address,
109+
.ndo_set_mac_address = eth_mac_addr,
122110
.ndo_get_stats64 = dummy_get_stats64,
123111
};
124112

@@ -134,6 +122,7 @@ static void dummy_setup(struct net_device *dev)
134122
dev->tx_queue_len = 0;
135123
dev->flags |= IFF_NOARP;
136124
dev->flags &= ~IFF_MULTICAST;
125+
dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
137126
dev->features |= NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_TSO;
138127
dev->features |= NETIF_F_HW_CSUM | NETIF_F_HIGHDMA | NETIF_F_LLTX;
139128
eth_hw_addr_random(dev);

0 commit comments

Comments
 (0)