Bluetooth: hci_qca: Add delay after power-off pulse

Matthias Kaehlcke · holtmann · commit 0ebcddd8e06e · 2019-02-27T08:44:33.000+01:00
During initialization the power-on pulse is currently sent inmediately
after the prior power-off pulse. With this initialization often fails
at boot time:

[   15.205224] Bluetooth: hci0: setting up wcn3990
[   17.341062] Bluetooth: hci0: command 0xfc00 tx timeout
[   22.101453] ERROR: Bluetooth initialization failed
[   25.337740] Bluetooth: hci0: Reading QCA version information failed (-110)

After a power-off pulse wait 10ms to give the controller time to power
off. Remove the previous short settling delay, it isn't needed anymore.

Signed-off-by: Matthias Kaehlcke &lt;mka@chromium.org&gt;
Reviewed-by: Balakrishna Godavarthi &lt;bgodavar@codeaurora.org&gt;
Signed-off-by: Marcel Holtmann &lt;marcel@holtmann.org&gt;
diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
@@ -1031,13 +1031,13 @@ static int qca_send_power_pulse(struct hci_uart *hu, bool on)
 	}
 
 	serdev_device_wait_until_sent(hu->serdev, timeout);
-
-	/* Wait for 100 uS for SoC to settle down */
-	usleep_range(100, 200);
 	hci_uart_set_flow_control(hu, false);
 
+	/* Give to controller time to boot/shutdown */
 	if (on)
 		msleep(100);
+	else
+		msleep(10);
 
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -1031,13 +1031,13 @@ static int qca_send_power_pulse(struct hci_uart *hu, bool on)`
`1031`	`1031`	`}`
`1032`	`1032`
`1033`	`1033`	`serdev_device_wait_until_sent(hu->serdev, timeout);`
`1034`		`-`
`1035`		`- /* Wait for 100 uS for SoC to settle down */`
`1036`		`- usleep_range(100, 200);`
`1037`	`1034`	`hci_uart_set_flow_control(hu, false);`
`1038`	`1035`
	`1036`	`+ /* Give to controller time to boot/shutdown */`
`1039`	`1037`	`if (on)`
`1040`	`1038`	`msleep(100);`
	`1039`	`+ else`
	`1040`	`+ msleep(10);`
`1041`	`1041`
`1042`	`1042`	`return 0;`
`1043`	`1043`	`}`