Skip to content

Commit 10492ee

Browse files
tmlindLee Jones
authored andcommitted
mfd: omap-usb-host: Fix dts probe of children
It currently only works if the parent bus uses "simple-bus". We currently try to probe children with non-existing compatible values. And we're missing .probe. I noticed this while testing devices configured to probe using ti-sysc interconnect target module driver. For that we also may want to rebind the driver, so let's remove __init and __exit. Signed-off-by: Tony Lindgren <tony@atomide.com> Acked-by: Roger Quadros <rogerq@ti.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>
1 parent a318c24 commit 10492ee

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

drivers/mfd/omap-usb-host.c

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -528,8 +528,8 @@ static int usbhs_omap_get_dt_pdata(struct device *dev,
528528
}
529529

530530
static const struct of_device_id usbhs_child_match_table[] = {
531-
{ .compatible = "ti,omap-ehci", },
532-
{ .compatible = "ti,omap-ohci", },
531+
{ .compatible = "ti,ehci-omap", },
532+
{ .compatible = "ti,ohci-omap3", },
533533
{ }
534534
};
535535

@@ -855,6 +855,7 @@ static struct platform_driver usbhs_omap_driver = {
855855
.pm = &usbhsomap_dev_pm_ops,
856856
.of_match_table = usbhs_omap_dt_ids,
857857
},
858+
.probe = usbhs_omap_probe,
858859
.remove = usbhs_omap_remove,
859860
};
860861

@@ -864,9 +865,9 @@ MODULE_ALIAS("platform:" USBHS_DRIVER_NAME);
864865
MODULE_LICENSE("GPL v2");
865866
MODULE_DESCRIPTION("usb host common core driver for omap EHCI and OHCI");
866867

867-
static int __init omap_usbhs_drvinit(void)
868+
static int omap_usbhs_drvinit(void)
868869
{
869-
return platform_driver_probe(&usbhs_omap_driver, usbhs_omap_probe);
870+
return platform_driver_register(&usbhs_omap_driver);
870871
}
871872

872873
/*
@@ -878,7 +879,7 @@ static int __init omap_usbhs_drvinit(void)
878879
*/
879880
fs_initcall_sync(omap_usbhs_drvinit);
880881

881-
static void __exit omap_usbhs_drvexit(void)
882+
static void omap_usbhs_drvexit(void)
882883
{
883884
platform_driver_unregister(&usbhs_omap_driver);
884885
}

0 commit comments

Comments
 (0)