Skip to content

Commit 119c366

Browse files
committed
ARM: sunxi: Remove useless allwinner,pull property
The allwinner,pull property set to NO_PULL was really considered our default (and wasn't even changing the default value in the code). Remove these properties to make it obvious that we do not set anything in such a case. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> Acked-by: Chen-Yu Tsai <wens@csie.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
1 parent d312f6f commit 119c366

File tree

85 files changed

+0
-321
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

85 files changed

+0
-321
lines changed

arch/arm/boot/dts/sun4i-a10-a1000.dts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,13 +188,11 @@
188188
emac_power_pin_a1000: emac_power_pin@0 {
189189
allwinner,pins = "PH15";
190190
allwinner,function = "gpio_out";
191-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
192191
};
193192

194193
led_pins_a1000: led_pins@0 {
195194
allwinner,pins = "PH10", "PH20";
196195
allwinner,function = "gpio_out";
197-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
198196
};
199197
};
200198

arch/arm/boot/dts/sun4i-a10-cubieboard.dts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@
168168
allwinner,pins = "PH20", "PH21";
169169
allwinner,function = "gpio_out";
170170
allwinner,drive = <SUN4I_PINCTRL_20_MA>;
171-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
172171
};
173172

174173
usb0_id_detect_pin: usb0_id_detect_pin@0 {

arch/arm/boot/dts/sun4i-a10-dserve-dsrv9703c.dts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,25 +180,21 @@
180180
bl_en_pin_dsrv9703c: bl_en_pin@0 {
181181
allwinner,pins = "PH7";
182182
allwinner,function = "gpio_out";
183-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
184183
};
185184

186185
codec_pa_pin: codec_pa_pin@0 {
187186
allwinner,pins = "PH15";
188187
allwinner,function = "gpio_out";
189-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
190188
};
191189

192190
motor_pins: motor_pins@0 {
193191
allwinner,pins = "PB3";
194192
allwinner,function = "gpio_out";
195-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
196193
};
197194

198195
touchscreen_pins: touchscreen_pins@0 {
199196
allwinner,pins = "PB13";
200197
allwinner,function = "gpio_out";
201-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
202198
};
203199

204200
usb0_id_detect_pin: usb0_id_detect_pin@0 {

arch/arm/boot/dts/sun4i-a10-gemei-g9.dts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,6 @@
158158
codec_pa_pin: codec_pa_pin@0 {
159159
allwinner,pins = "PH15";
160160
allwinner,function = "gpio_out";
161-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
162161
};
163162
};
164163

arch/arm/boot/dts/sun4i-a10-hackberry.dts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,13 +131,11 @@
131131
hackberry_hogs: hogs@0 {
132132
allwinner,pins = "PH19";
133133
allwinner,function = "gpio_out";
134-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
135134
};
136135

137136
usb2_vbus_pin_hackberry: usb2_vbus_pin@0 {
138137
allwinner,pins = "PH12";
139138
allwinner,function = "gpio_out";
140-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
141139
};
142140
};
143141

arch/arm/boot/dts/sun4i-a10-inet1.dts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,13 +182,11 @@
182182
bl_en_pin_inet: bl_en_pin@0 {
183183
allwinner,pins = "PH7";
184184
allwinner,function = "gpio_out";
185-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
186185
};
187186

188187
touchscreen_wake_pin: touchscreen_wake_pin@0 {
189188
allwinner,pins = "PB13";
190189
allwinner,function = "gpio_out";
191-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
192190
};
193191

194192
usb0_id_detect_pin: usb0_id_detect_pin@0 {

arch/arm/boot/dts/sun4i-a10-jesurun-q5.dts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,13 +165,11 @@
165165
emac_power_pin_q5: emac_power_pin@0 {
166166
allwinner,pins = "PH19";
167167
allwinner,function = "gpio_out";
168-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
169168
};
170169

171170
led_pins_q5: led_pins@0 {
172171
allwinner,pins = "PH20";
173172
allwinner,function = "gpio_out";
174-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
175173
};
176174
};
177175

arch/arm/boot/dts/sun4i-a10-marsboard.dts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@
166166
led_pins_marsboard: led_pins@0 {
167167
allwinner,pins = "PB5", "PB6", "PB7", "PB8";
168168
allwinner,function = "gpio_out";
169-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
170169
};
171170

172171
usb0_id_detect_pin: usb0_id_detect_pin@0 {

arch/arm/boot/dts/sun4i-a10-mk802.dts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,19 +93,16 @@
9393
usb0_id_detect_pin: usb0_id_detect_pin@0 {
9494
allwinner,pins = "PH4";
9595
allwinner,function = "gpio_in";
96-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
9796
};
9897

9998
usb0_vbus_detect_pin: usb0_vbus_detect_pin@0 {
10099
allwinner,pins = "PH5";
101100
allwinner,function = "gpio_in";
102-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
103101
};
104102

105103
usb2_vbus_pin_mk802: usb2_vbus_pin@0 {
106104
allwinner,pins = "PH12";
107105
allwinner,function = "gpio_out";
108-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
109106
};
110107
};
111108

arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,14 +170,12 @@
170170
ahci_pwr_pin_olinuxinolime: ahci_pwr_pin@1 {
171171
allwinner,pins = "PC3";
172172
allwinner,function = "gpio_out";
173-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
174173
};
175174

176175
led_pins_olinuxinolime: led_pins@0 {
177176
allwinner,pins = "PH2";
178177
allwinner,function = "gpio_out";
179178
allwinner,drive = <SUN4I_PINCTRL_20_MA>;
180-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
181179
};
182180

183181
usb0_id_detect_pin: usb0_id_detect_pin@0 {

arch/arm/boot/dts/sun4i-a10-pcduino.dts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,13 +172,11 @@
172172
led_pins_pcduino: led_pins@0 {
173173
allwinner,pins = "PH15", "PH16";
174174
allwinner,function = "gpio_out";
175-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
176175
};
177176

178177
key_pins_pcduino: key_pins@0 {
179178
allwinner,pins = "PH17", "PH18", "PH19";
180179
allwinner,function = "gpio_in";
181-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
182180
};
183181

184182
usb0_id_detect_pin: usb0_id_detect_pin@0 {

arch/arm/boot/dts/sun4i-a10-pcduino2.dts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@
5959
usb2_vbus_pin_pcduino2: usb2_vbus_pin@0 {
6060
allwinner,pins = "PD2";
6161
allwinner,function = "gpio_out";
62-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
6362
};
6463
};
6564

arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,19 +166,16 @@
166166
bl_en_pin_protab: bl_en_pin@0 {
167167
allwinner,pins = "PH7";
168168
allwinner,function = "gpio_out";
169-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
170169
};
171170

172171
codec_pa_pin: codec_pa_pin@0 {
173172
allwinner,pins = "PH15";
174173
allwinner,function = "gpio_out";
175-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
176174
};
177175

178176
touchscreen_pins: touchscreen_pins@0 {
179177
allwinner,pins = "PA5", "PB13";
180178
allwinner,function = "gpio_out";
181-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
182179
};
183180

184181
usb0_id_detect_pin: usb0_id_detect_pin@0 {

arch/arm/boot/dts/sun4i-a10.dtsi

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -981,57 +981,48 @@
981981
"PA11", "PA12", "PA13", "PA14",
982982
"PA15", "PA16";
983983
allwinner,function = "emac";
984-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
985984
};
986985

987986
i2c0_pins_a: i2c0@0 {
988987
allwinner,pins = "PB0", "PB1";
989988
allwinner,function = "i2c0";
990-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
991989
};
992990

993991
i2c1_pins_a: i2c1@0 {
994992
allwinner,pins = "PB18", "PB19";
995993
allwinner,function = "i2c1";
996-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
997994
};
998995

999996
i2c2_pins_a: i2c2@0 {
1000997
allwinner,pins = "PB20", "PB21";
1001998
allwinner,function = "i2c2";
1002-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
1003999
};
10041000

10051001
ir0_rx_pins_a: ir0@0 {
10061002
allwinner,pins = "PB4";
10071003
allwinner,function = "ir0";
1008-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
10091004
};
10101005

10111006
ir0_tx_pins_a: ir0@1 {
10121007
allwinner,pins = "PB3";
10131008
allwinner,function = "ir0";
1014-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
10151009
};
10161010

10171011
ir1_rx_pins_a: ir1@0 {
10181012
allwinner,pins = "PB23";
10191013
allwinner,function = "ir1";
1020-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
10211014
};
10221015

10231016
ir1_tx_pins_a: ir1@1 {
10241017
allwinner,pins = "PB22";
10251018
allwinner,function = "ir1";
1026-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
10271019
};
10281020

10291021
mmc0_pins_a: mmc0@0 {
10301022
allwinner,pins = "PF0", "PF1", "PF2",
10311023
"PF3", "PF4", "PF5";
10321024
allwinner,function = "mmc0";
10331025
allwinner,drive = <SUN4I_PINCTRL_30_MA>;
1034-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
10351026
};
10361027

10371028
mmc0_cd_pin_reference_design: mmc0_cd_pin@0 {
@@ -1043,25 +1034,21 @@
10431034
ps20_pins_a: ps20@0 {
10441035
allwinner,pins = "PI20", "PI21";
10451036
allwinner,function = "ps2";
1046-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
10471037
};
10481038

10491039
ps21_pins_a: ps21@0 {
10501040
allwinner,pins = "PH12", "PH13";
10511041
allwinner,function = "ps2";
1052-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
10531042
};
10541043

10551044
pwm0_pins_a: pwm0@0 {
10561045
allwinner,pins = "PB2";
10571046
allwinner,function = "pwm";
1058-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
10591047
};
10601048

10611049
pwm1_pins_a: pwm1@0 {
10621050
allwinner,pins = "PI3";
10631051
allwinner,function = "pwm";
1064-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
10651052
};
10661053

10671054
spdif_tx_pins_a: spdif@0 {
@@ -1073,67 +1060,56 @@
10731060
spi0_pins_a: spi0@0 {
10741061
allwinner,pins = "PI11", "PI12", "PI13";
10751062
allwinner,function = "spi0";
1076-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
10771063
};
10781064

10791065
spi0_cs0_pins_a: spi0_cs0@0 {
10801066
allwinner,pins = "PI10";
10811067
allwinner,function = "spi0";
1082-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
10831068
};
10841069

10851070
spi1_pins_a: spi1@0 {
10861071
allwinner,pins = "PI17", "PI18", "PI19";
10871072
allwinner,function = "spi1";
1088-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
10891073
};
10901074

10911075
spi1_cs0_pins_a: spi1_cs0@0 {
10921076
allwinner,pins = "PI16";
10931077
allwinner,function = "spi1";
1094-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
10951078
};
10961079

10971080
spi2_pins_a: spi2@0 {
10981081
allwinner,pins = "PC20", "PC21", "PC22";
10991082
allwinner,function = "spi2";
1100-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
11011083
};
11021084

11031085
spi2_pins_b: spi2@1 {
11041086
allwinner,pins = "PB15", "PB16", "PB17";
11051087
allwinner,function = "spi2";
1106-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
11071088
};
11081089

11091090
spi2_cs0_pins_a: spi2_cs0@0 {
11101091
allwinner,pins = "PC19";
11111092
allwinner,function = "spi2";
1112-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
11131093
};
11141094

11151095
spi2_cs0_pins_b: spi2_cs0@1 {
11161096
allwinner,pins = "PB14";
11171097
allwinner,function = "spi2";
1118-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
11191098
};
11201099

11211100
uart0_pins_a: uart0@0 {
11221101
allwinner,pins = "PB22", "PB23";
11231102
allwinner,function = "uart0";
1124-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
11251103
};
11261104

11271105
uart0_pins_b: uart0@1 {
11281106
allwinner,pins = "PF2", "PF4";
11291107
allwinner,function = "uart0";
1130-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
11311108
};
11321109

11331110
uart1_pins_a: uart1@0 {
11341111
allwinner,pins = "PA10", "PA11";
11351112
allwinner,function = "uart1";
1136-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
11371113
};
11381114
};
11391115

arch/arm/boot/dts/sun5i-a10s-auxtek-t003.dts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@
118118
allwinner,pins = "PB2";
119119
allwinner,function = "gpio_out";
120120
allwinner,drive = <SUN4I_PINCTRL_20_MA>;
121-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
122121
};
123122
};
124123

arch/arm/boot/dts/sun5i-a10s-auxtek-t004.dts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,14 +144,12 @@
144144
mmc1_vcc_en_pin_t004: mmc1_vcc_en_pin@0 {
145145
allwinner,pins = "PB18";
146146
allwinner,function = "gpio_out";
147-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
148147
};
149148

150149
led_pins_t004: led_pins@0 {
151150
allwinner,pins = "PB2";
152151
allwinner,function = "gpio_out";
153152
allwinner,drive = <SUN4I_PINCTRL_20_MA>;
154-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
155153
};
156154
};
157155

arch/arm/boot/dts/sun5i-a10s-mk802.dts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,6 @@
118118
led_pins_mk802: led_pins@0 {
119119
allwinner,pins = "PB2";
120120
allwinner,function = "gpio_out";
121-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
122121
};
123122

124123
mmc0_cd_pin_mk802: mmc0_cd_pin@0 {
@@ -130,7 +129,6 @@
130129
usb1_vbus_pin_mk802: usb1_vbus_pin@0 {
131130
allwinner,pins = "PB10";
132131
allwinner,function = "gpio_out";
133-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
134132
};
135133
};
136134

arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -217,13 +217,11 @@
217217
allwinner,pins = "PE3";
218218
allwinner,function = "gpio_out";
219219
allwinner,drive = <SUN4I_PINCTRL_20_MA>;
220-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
221220
};
222221

223222
usb1_vbus_pin_olinuxino_m: usb1_vbus_pin@0 {
224223
allwinner,pins = "PB10";
225224
allwinner,function = "gpio_out";
226-
allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
227225
};
228226

229227
usb0_id_detect_pin: usb0_id_detect_pin@0 {

0 commit comments

Comments
 (0)