Skip to content

Commit 1306ad4

Browse files
bzolnieraxboe
authored andcommitted
block: remove redundant 'default n' from Kconfig-s
'default n' is the default value for any bool or tristate Kconfig setting so there is no need to write it explicitly. Also since commit f467c56 ("kconfig: only write '# CONFIG_FOO is not set' for visible symbols") the Kconfig behavior is the same regardless of 'default n' being present or not: ... One side effect of (and the main motivation for) this change is making the following two definitions behave exactly the same: config FOO bool config FOO bool default n With this change, neither of these will generate a '# CONFIG_FOO is not set' line (assuming FOO isn't selected/implied). That might make it clearer to people that a bare 'default n' is redundant. ... Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 766c8ce commit 1306ad4

File tree

2 files changed

+0
-10
lines changed

2 files changed

+0
-10
lines changed

block/Kconfig

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ config BLK_DEV_BSG
7474

7575
config BLK_DEV_BSGLIB
7676
bool "Block layer SG support v4 helper lib"
77-
default n
7877
select BLK_DEV_BSG
7978
select BLK_SCSI_REQUEST
8079
help
@@ -107,7 +106,6 @@ config BLK_DEV_ZONED
107106
config BLK_DEV_THROTTLING
108107
bool "Block layer bio throttling support"
109108
depends on BLK_CGROUP=y
110-
default n
111109
---help---
112110
Block layer bio throttling support. It can be used to limit
113111
the IO rate to a device. IO rate policies are per cgroup and
@@ -119,7 +117,6 @@ config BLK_DEV_THROTTLING
119117
config BLK_DEV_THROTTLING_LOW
120118
bool "Block throttling .low limit interface support (EXPERIMENTAL)"
121119
depends on BLK_DEV_THROTTLING
122-
default n
123120
---help---
124121
Add .low limit interface for block throttling. The low limit is a best
125122
effort limit to prioritize cgroups. Depending on the setting, the limit
@@ -130,7 +127,6 @@ config BLK_DEV_THROTTLING_LOW
130127

131128
config BLK_CMDLINE_PARSER
132129
bool "Block device command line partition parser"
133-
default n
134130
---help---
135131
Enabling this option allows you to specify the partition layout from
136132
the kernel boot args. This is typically of use for embedded devices
@@ -141,7 +137,6 @@ config BLK_CMDLINE_PARSER
141137

142138
config BLK_WBT
143139
bool "Enable support for block device writeback throttling"
144-
default n
145140
---help---
146141
Enabling this option enables the block layer to throttle buffered
147142
background writeback from the VM, making it more smooth and having
@@ -152,7 +147,6 @@ config BLK_WBT
152147
config BLK_CGROUP_IOLATENCY
153148
bool "Enable support for latency based cgroup IO protection"
154149
depends on BLK_CGROUP=y
155-
default n
156150
---help---
157151
Enabling this option enables the .latency interface for IO throttling.
158152
The IO controller will attempt to maintain average IO latencies below
@@ -163,7 +157,6 @@ config BLK_CGROUP_IOLATENCY
163157

164158
config BLK_WBT_SQ
165159
bool "Single queue writeback throttling"
166-
default n
167160
depends on BLK_WBT
168161
---help---
169162
Enable writeback throttling by default on legacy single queue devices

block/Kconfig.iosched

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ config IOSCHED_CFQ
3636
config CFQ_GROUP_IOSCHED
3737
bool "CFQ Group Scheduling support"
3838
depends on IOSCHED_CFQ && BLK_CGROUP
39-
default n
4039
---help---
4140
Enable group IO scheduling in CFQ.
4241

@@ -82,7 +81,6 @@ config MQ_IOSCHED_KYBER
8281

8382
config IOSCHED_BFQ
8483
tristate "BFQ I/O scheduler"
85-
default n
8684
---help---
8785
BFQ I/O scheduler for BLK-MQ. BFQ distributes the bandwidth of
8886
of the device among all processes according to their weights,
@@ -94,7 +92,6 @@ config IOSCHED_BFQ
9492
config BFQ_GROUP_IOSCHED
9593
bool "BFQ hierarchical scheduling support"
9694
depends on IOSCHED_BFQ && BLK_CGROUP
97-
default n
9895
---help---
9996

10097
Enable hierarchical scheduling in BFQ, using the blkio

0 commit comments

Comments
 (0)