mlx5: ensure 0 is returned when vport is zero

Colin Ian King · davem330 · commit 1547f538c145 · 2017-08-18T16:28:40.000-07:00
Currently, if vport is zero then then an uninialized return status in err is returned. Since the only return status at the end of the function esw_add_uc_addr is zero for the current set of return paths we may as well just return 0 rather than err to fix this issue. Detected by CoverityScan, CID#1452698 ("Uninitialized scalar variable") Fixes: eeb66cd ("net/mlx5: Separate between E-Switch and MPFS") Signed-off-by: Colin Ian King <colin.king@canonical.com> Reviewed-by: Leon Romanovsky <leonro@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c
@@ -401,7 +401,7 @@ static int esw_add_uc_addr(struct mlx5_eswitch *esw, struct vport_addr *vaddr)
 	esw_debug(esw->dev, "\tADDED UC MAC: vport[%d] %pM fr(%p)\n",
 		  vport, mac, vaddr->flow_rule);
 
-	return err;
+	return 0;
 }
 
 static int esw_del_uc_addr(struct mlx5_eswitch *esw, struct vport_addr *vaddr)

Original file line number	Diff line number	Diff line change
`@@ -401,7 +401,7 @@ static int esw_add_uc_addr(struct mlx5_eswitch esw, struct vport_addr vaddr)`
`401`	`401`	`esw_debug(esw->dev, "\tADDED UC MAC: vport[%d] %pM fr(%p)\n",`
`402`	`402`	`vport, mac, vaddr->flow_rule);`
`403`	`403`
`404`		`- return err;`
	`404`	`+ return 0;`
`405`	`405`	`}`
`406`	`406`
`407`	`407`	`static int esw_del_uc_addr(struct mlx5_eswitch esw, struct vport_addr vaddr)`