cgroup: drop const from @buffer of cftype->write_string()

htejun · htejun · commit 162320050bfd · 2014-03-13T15:48:41.000-04:00
cftype->write_string() just passes on the writeable buffer from kernfs and there's no reason to add const restriction on the buffer. The only thing const achieves is unnecessarily complicating parsing of the buffer. Drop const from @buffer. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Li Zefan <lizefan@huawei.com> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Paul Mackerras <paulus@samba.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> Cc: Daniel Borkmann <dborkman@redhat.com> Cc: Michal Hocko <mhocko@suse.cz> Cc: Johannes Weiner <hannes@cmpxchg.org> Cc: Balbir Singh <bsingharora@gmail.com> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
diff --git a/block/blk-throttle.c b/block/blk-throttle.c
@@ -1408,13 +1408,13 @@ static int tg_set_conf(struct cgroup_subsys_state *css, struct cftype *cft,
 }
 
 static int tg_set_conf_u64(struct cgroup_subsys_state *css, struct cftype *cft,
-			   const char *buf)
+			   char *buf)
 {
 	return tg_set_conf(css, cft, buf, true);
 }
 
 static int tg_set_conf_uint(struct cgroup_subsys_state *css, struct cftype *cft,
-			    const char *buf)
+			    char *buf)
 {
 	return tg_set_conf(css, cft, buf, false);
 }
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
@@ -1701,13 +1701,13 @@ static int __cfqg_set_weight_device(struct cgroup_subsys_state *css,
 }
 
 static int cfqg_set_weight_device(struct cgroup_subsys_state *css,
-				  struct cftype *cft, const char *buf)
+				  struct cftype *cft, char *buf)
 {
 	return __cfqg_set_weight_device(css, cft, buf, false);
 }
 
 static int cfqg_set_leaf_weight_device(struct cgroup_subsys_state *css,
-				       struct cftype *cft, const char *buf)
+				       struct cftype *cft, char *buf)
 {
 	return __cfqg_set_weight_device(css, cft, buf, true);
 }
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
@@ -454,7 +454,7 @@ struct cftype {
 	 * Returns 0 or -ve error code.
 	 */
 	int (*write_string)(struct cgroup_subsys_state *css, struct cftype *cft,
-			    const char *buffer);
+			    char *buffer);
 	/*
 	 * trigger() callback can be used to get some kick from the
 	 * userspace, when the actual string written is not important
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
@@ -2143,7 +2143,7 @@ static int cgroup_procs_write(struct cgroup_subsys_state *css,
 }
 
 static int cgroup_release_agent_write(struct cgroup_subsys_state *css,
-				      struct cftype *cft, const char *buffer)
+				      struct cftype *cft, char *buffer)
 {
 	struct cgroup_root *root = css->cgroup->root;
 
diff --git a/kernel/cgroup_freezer.c b/kernel/cgroup_freezer.c
@@ -442,7 +442,7 @@ static void freezer_change_state(struct freezer *freezer, bool freeze)
 }
 
 static int freezer_write(struct cgroup_subsys_state *css, struct cftype *cft,
-			 const char *buffer)
+			 char *buffer)
 {
 	bool freeze;
 
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
@@ -1610,7 +1610,7 @@ static int cpuset_write_s64(struct cgroup_subsys_state *css, struct cftype *cft,
  * Common handling for a write to a "cpus" or "mems" file.
  */
 static int cpuset_write_resmask(struct cgroup_subsys_state *css,
-				struct cftype *cft, const char *buf)
+				struct cftype *cft, char *buf)
 {
 	struct cpuset *cs = css_cs(css);
 	struct cpuset *trialcs;
diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
@@ -254,7 +254,7 @@ static u64 hugetlb_cgroup_read_u64(struct cgroup_subsys_state *css,
 }
 
 static int hugetlb_cgroup_write(struct cgroup_subsys_state *css,
-				struct cftype *cft, const char *buffer)
+				struct cftype *cft, char *buffer)
 {
 	int idx, name, ret;
 	unsigned long long val;
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
@@ -5242,7 +5242,7 @@ static int memcg_update_kmem_limit(struct mem_cgroup *memcg,
  * RES_LIMIT.
  */
 static int mem_cgroup_write(struct cgroup_subsys_state *css, struct cftype *cft,
-			    const char *buffer)
+			    char *buffer)
 {
 	struct mem_cgroup *memcg = mem_cgroup_from_css(css);
 	enum res_type type;
@@ -6063,7 +6063,7 @@ static void memcg_event_ptable_queue_proc(struct file *file,
  * Interpretation of args is defined by control file implementation.
  */
 static int memcg_write_event_control(struct cgroup_subsys_state *css,
-				     struct cftype *cft, const char *buffer)
+				     struct cftype *cft, char *buffer)
 {
 	struct mem_cgroup *memcg = mem_cgroup_from_css(css);
 	struct mem_cgroup_event *event;
diff --git a/net/core/netprio_cgroup.c b/net/core/netprio_cgroup.c
@@ -186,7 +186,7 @@ static int read_priomap(struct seq_file *sf, void *v)
 }
 
 static int write_priomap(struct cgroup_subsys_state *css, struct cftype *cft,
-			 const char *buffer)
+			 char *buffer)
 {
 	char devname[IFNAMSIZ + 1];
 	struct net_device *dev;
diff --git a/net/ipv4/tcp_memcontrol.c b/net/ipv4/tcp_memcontrol.c
@@ -103,7 +103,7 @@ static int tcp_update_limit(struct mem_cgroup *memcg, u64 val)
 }
 
 static int tcp_cgroup_write(struct cgroup_subsys_state *css, struct cftype *cft,
-			    const char *buffer)
+			    char *buffer)
 {
 	struct mem_cgroup *memcg = mem_cgroup_from_css(css);
 	unsigned long long val;
diff --git a/security/device_cgroup.c b/security/device_cgroup.c
@@ -496,7 +496,7 @@ static inline bool has_children(struct dev_cgroup *devcgroup)
  * parent cgroup has the access you're asking for.
  */
 static int devcgroup_update_access(struct dev_cgroup *devcgroup,
-				   int filetype, const char *buffer)
+				   int filetype, char *buffer)
 {
 	const char *b;
 	char temp[12];		/* 11 + 1 characters needed for a u32 */
@@ -652,7 +652,7 @@ static int devcgroup_update_access(struct dev_cgroup *devcgroup,
 }
 
 static int devcgroup_access_write(struct cgroup_subsys_state *css,
-				  struct cftype *cft, const char *buffer)
+				  struct cftype *cft, char *buffer)
 {
 	int retval;
 

Original file line number	Diff line number	Diff line change
`@@ -1408,13 +1408,13 @@ static int tg_set_conf(struct cgroup_subsys_state css, struct cftype cft,`
`1408`	`1408`	`}`
`1409`	`1409`
`1410`	`1410`	`static int tg_set_conf_u64(struct cgroup_subsys_state css, struct cftype cft,`
`1411`		`- const char *buf)`
	`1411`	`+ char *buf)`
`1412`	`1412`	`{`
`1413`	`1413`	`return tg_set_conf(css, cft, buf, true);`
`1414`	`1414`	`}`
`1415`	`1415`
`1416`	`1416`	`static int tg_set_conf_uint(struct cgroup_subsys_state css, struct cftype cft,`
`1417`		`- const char *buf)`
	`1417`	`+ char *buf)`
`1418`	`1418`	`{`
`1419`	`1419`	`return tg_set_conf(css, cft, buf, false);`
`1420`	`1420`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1701,13 +1701,13 @@ static int __cfqg_set_weight_device(struct cgroup_subsys_state *css,`
`1701`	`1701`	`}`
`1702`	`1702`
`1703`	`1703`	`static int cfqg_set_weight_device(struct cgroup_subsys_state *css,`
`1704`		`- struct cftype cft, const char buf)`
	`1704`	`+ struct cftype cft, char buf)`
`1705`	`1705`	`{`
`1706`	`1706`	`return __cfqg_set_weight_device(css, cft, buf, false);`
`1707`	`1707`	`}`
`1708`	`1708`
`1709`	`1709`	`static int cfqg_set_leaf_weight_device(struct cgroup_subsys_state *css,`
`1710`		`- struct cftype cft, const char buf)`
	`1710`	`+ struct cftype cft, char buf)`
`1711`	`1711`	`{`
`1712`	`1712`	`return __cfqg_set_weight_device(css, cft, buf, true);`
`1713`	`1713`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2143,7 +2143,7 @@ static int cgroup_procs_write(struct cgroup_subsys_state *css,`
`2143`	`2143`	`}`
`2144`	`2144`
`2145`	`2145`	`static int cgroup_release_agent_write(struct cgroup_subsys_state *css,`
`2146`		`- struct cftype cft, const char buffer)`
	`2146`	`+ struct cftype cft, char buffer)`
`2147`	`2147`	`{`
`2148`	`2148`	`struct cgroup_root *root = css->cgroup->root;`
`2149`	`2149`
Original file line number	Diff line number	Diff line change
`@@ -442,7 +442,7 @@ static void freezer_change_state(struct freezer *freezer, bool freeze)`
`442`	`442`	`}`
`443`	`443`
`444`	`444`	`static int freezer_write(struct cgroup_subsys_state css, struct cftype cft,`
`445`		`- const char *buffer)`
	`445`	`+ char *buffer)`
`446`	`446`	`{`
`447`	`447`	`bool freeze;`
`448`	`448`
Original file line number	Diff line number	Diff line change
`@@ -1610,7 +1610,7 @@ static int cpuset_write_s64(struct cgroup_subsys_state css, struct cftype cft,`
`1610`	`1610`	`* Common handling for a write to a "cpus" or "mems" file.`
`1611`	`1611`	`*/`
`1612`	`1612`	`static int cpuset_write_resmask(struct cgroup_subsys_state *css,`
`1613`		`- struct cftype cft, const char buf)`
	`1613`	`+ struct cftype cft, char buf)`
`1614`	`1614`	`{`
`1615`	`1615`	`struct cpuset *cs = css_cs(css);`
`1616`	`1616`	`struct cpuset *trialcs;`
Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,7 @@ static u64 hugetlb_cgroup_read_u64(struct cgroup_subsys_state *css,`
`254`	`254`	`}`
`255`	`255`
`256`	`256`	`static int hugetlb_cgroup_write(struct cgroup_subsys_state *css,`
`257`		`- struct cftype cft, const char buffer)`
	`257`	`+ struct cftype cft, char buffer)`
`258`	`258`	`{`
`259`	`259`	`int idx, name, ret;`
`260`	`260`	`unsigned long long val;`
Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ static int read_priomap(struct seq_file sf, void v)`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`static int write_priomap(struct cgroup_subsys_state css, struct cftype cft,`
`189`		`- const char *buffer)`
	`189`	`+ char *buffer)`
`190`	`190`	`{`
`191`	`191`	`char devname[IFNAMSIZ + 1];`
`192`	`192`	`struct net_device *dev;`
Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ static int tcp_update_limit(struct mem_cgroup *memcg, u64 val)`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`static int tcp_cgroup_write(struct cgroup_subsys_state css, struct cftype cft,`
`106`		`- const char *buffer)`
	`106`	`+ char *buffer)`
`107`	`107`	`{`
`108`	`108`	`struct mem_cgroup *memcg = mem_cgroup_from_css(css);`
`109`	`109`	`unsigned long long val;`