Skip to content

Commit 167b1f0

Browse files
committed
agp/ati: Use PCI_COMMAND instead of hard-coded 4
We're accessing the PCI_COMMAND register here, so use the appropriate #define. The bit we're writing (1 << 14) isn't defined by the PCI or PCIe spec, so we don't have a name for it. No functional change. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
1 parent d357253 commit 167b1f0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/char/agp/ati-agp.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,8 +221,8 @@ static int ati_configure(void)
221221
readl(ati_generic_private.registers+ATI_GART_FEATURE_ID); /* PCI Posting.*/
222222

223223
/* SIGNALED_SYSTEM_ERROR @ NB_STATUS */
224-
pci_read_config_dword(agp_bridge->dev, 4, &temp);
225-
pci_write_config_dword(agp_bridge->dev, 4, temp | (1<<14));
224+
pci_read_config_dword(agp_bridge->dev, PCI_COMMAND, &temp);
225+
pci_write_config_dword(agp_bridge->dev, PCI_COMMAND, temp | (1<<14));
226226

227227
/* Write out the address of the gatt table */
228228
writel(agp_bridge->gatt_bus_addr, ati_generic_private.registers+ATI_GART_BASE);

0 commit comments

Comments
 (0)