platform: x86: remove unnecessary platform_set_drvdata()

Jingoo Han · Matthew Garrett · commit 18a0393543fa · 2013-09-05T08:52:18.000-04:00
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han &lt;jg1.han@samsung.com&gt;
Signed-off-by: Matthew Garrett &lt;matthew.garrett@nebula.com&gt;
diff --git a/drivers/platform/x86/compal-laptop.c b/drivers/platform/x86/compal-laptop.c
@@ -1083,7 +1083,6 @@ static int compal_remove(struct platform_device *pdev)
 	hwmon_device_unregister(data->hwmon_dev);
 	power_supply_unregister(&data->psy);
 
-	platform_set_drvdata(pdev, NULL);
 	kfree(data);
 
 	sysfs_remove_group(&pdev->dev.kobj, &compal_attribute_group);
diff --git a/drivers/platform/x86/intel_mid_powerbtn.c b/drivers/platform/x86/intel_mid_powerbtn.c
@@ -128,7 +128,6 @@ static int mfld_pb_remove(struct platform_device *pdev)
 
 	free_irq(irq, input);
 	input_unregister_device(input);
-	platform_set_drvdata(pdev, NULL);
 
 	return 0;
 }
diff --git a/drivers/platform/x86/intel_mid_thermal.c b/drivers/platform/x86/intel_mid_thermal.c
@@ -542,7 +542,6 @@ static int mid_thermal_remove(struct platform_device *pdev)
 	}
 
 	kfree(pinfo);
-	platform_set_drvdata(pdev, NULL);
 
 	/* Stop the ADC */
 	return configure_adc(0);

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,6 @@ static int mfld_pb_remove(struct platform_device *pdev)`
`128`	`128`
`129`	`129`	`free_irq(irq, input);`
`130`	`130`	`input_unregister_device(input);`
`131`		`- platform_set_drvdata(pdev, NULL);`
`132`	`131`
`133`	`132`	`return 0;`
`134`	`133`	`}`
Original file line number	Diff line number	Diff line change
`@@ -542,7 +542,6 @@ static int mid_thermal_remove(struct platform_device *pdev)`
`542`	`542`	`}`
`543`	`543`
`544`	`544`	`kfree(pinfo);`
`545`		`- platform_set_drvdata(pdev, NULL);`
`546`	`545`
`547`	`546`	`/* Stop the ADC */`
`548`	`547`	`return configure_adc(0);`